[Installer] Cleaning up dead code for App Launcher / App Host installs.

chrome/installer/setup/app_launcher_installer.h

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.

[grt (UTC plus 2), 2015/01/08 21:41:49]

nit: no (c) in the latest copyright template
(http://www.chromium.org/developers/coding-style#TOC-File-headers)

[huangs, 2015/01/18 01:18:23]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// The App Launcher is an adjunct product of the Google Chrome Browser, but it

[grt (UTC plus 2), 2015/01/08 21:41:49]

nit: "the Google Chrome Browser" -> "Google Chrome"

[huangs, 2015/01/18 01:18:24]

Done.

+// has a distinct registry entry. The functions in this file tap into various
+// points in installer flow to update the App Launcher's registry, including the
+// removal of deprecated app commands. This concentrates ugly code to to one
+// place to facilitate future refactoring.
+
+#ifndef CHROME_INSTALLER_SETUP_APP_LAUNCHER_INSTALLER_H_
+#define CHROME_INSTALLER_SETUP_APP_LAUNCHER_INSTALLER_H_
+
+#if defined(GOOGLE_CHROME_BUILD)
+
+#include <windows.h>
+
+namespace base {
+class FilePath;
+class Version;
+}  // namespace base
+
+class WorkItemList;
+
+namespace installer {
+
+class InstallerState;
+
+namespace app_launcher_installer {

[grt (UTC plus 2), 2015/01/08 21:41:49]

nix this extra namespace: the installer namespace is fine for this.

[huangs, 2015/01/18 01:18:23]

I want to make it very easy to find entry points to this rather hacky feature. 
Will remove the namespace if you insist.

[grt (UTC plus 2), 2015/01/20 21:30:22]

Use of namespaces is somewhat discouraged (see
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/OIkJO2KQKTQ/YQzUS...,
for example). Since these functions are grouped in this header and are
well-named, I don't think there's a need to further mark them with a namespace.

[huangs, 2015/01/20 23:26:00]

Removed.

+
+// Create Version key for a App Launcher (if not already present) and sets the
+// new product version as the last step.  We need this for App Launcher in
+// order for shadow registry key to work.
+void AddAppLauncherVersionKeyWorkItems(
+    HKEY root,
+    const base::Version& new_version,
+    bool add_language_identifier,
+    WorkItemList* list);
+
+// Adds work item to unconditionally remove legacy executables.
+void AddRemoveLegacyAppHostExeWorkItems(const base::FilePath& target_path,
+                                        const base::FilePath& temp_path,
+                                        WorkItemList* list);
+
+// Adds work item to unconditionally remove legacy app commands like
+// "install-application", "install-extension", and
+// "quick-enable-application-host".
+void AddRemoveLegacyAppCommandsWorkItems(
+    const InstallerState& installer_state,
+    WorkItemList* work_item_list);
+
+// Called during uninstall, to remove "shadow" registry key for App Launcher.

[grt (UTC plus 2), 2015/01/08 21:41:49]

Document what the function does rather than when it's called. Also, please avoid
"shadow" throughout. It's a subjective term that's irrelevant to the
implementation. The important technical detail is that the app launcher has its
own registration with Google Update that is kept in sync with Google Chrome's.

[huangs, 2015/01/18 01:18:23]

Done.

+// Note: The key is added by App Launcher in SetDidRunForNDayActiveStats().
+void RemoveShadowKey(HKEY reg_root);

[grt (UTC plus 2), 2015/01/08 21:41:49]

RemoveShadowKey -> RemoveAppLauncherVersionKey, and move this so that it
immediately follows the correspoding Add function above.

[huangs, 2015/01/18 01:18:24]

Done.

+
+}  // namespace app_launcher_installer
+}  // namespace installer
+
+#endif  // defined(GOOGLE_CHROME_BUILD)
+
+#endif  // CHROME_INSTALLER_SETUP_APP_LAUNCHER_INSTALLER_H_