Cast: Forcing codec initialization on a designated thread

media/cast/video_receiver/video_receiver.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cast/video_receiver/video_receiver.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 106 matching lines @@
     DCHECK(false) << "Invalid crypto configuration";
   }
 
   framer_.reset(new Framer(cast_environment->Clock(),
                            incoming_payload_feedback_.get(),
                            video_config.incoming_ssrc,
                            video_config.decoder_faster_than_max_frame_rate,
                            max_unacked_frames));
   if (!video_config.use_external_decoder) {
     video_decoder_.reset(new VideoDecoder(video_config, cast_environment));
+    InitDecoder();
   }
 
   rtcp_.reset(
       new Rtcp(cast_environment_,
                NULL,
                packet_sender,
                NULL,
                rtp_video_receiver_statistics_.get(),
                video_config.rtcp_mode,
                base::TimeDelta::FromMilliseconds(video_config.rtcp_interval),
                video_config.feedback_ssrc,
                video_config.incoming_ssrc,
                video_config.rtcp_c_name));
 }
 
 VideoReceiver::~VideoReceiver() {}
 
 void VideoReceiver::InitializeTimers() {
   DCHECK(cast_environment_->CurrentlyOn(CastEnvironment::MAIN));
   ScheduleNextRtcpReport();
   ScheduleNextCastMessage();
 }
 
+void VideoReceiver::InitDecoder() {

[pwestin, 2013/11/21 19:10:42]

instead of having this code here; why not post the task in the constructor of
the codec ?

[mikhal, 2013/11/21 19:27:00]

Had th same thought, but wasn't sure what's better. Will do now. 
On 2013/11/21 19:10:42, pwestin wrote:

+  cast_environment_->PostTask(CastEnvironment::VIDEO_DECODER, FROM_HERE,
+      base::Bind(&VideoReceiver::InitDecoderThread,
+                 weak_factory_.GetWeakPtr()));
+}
+
+void VideoReceiver::InitDecoderThread() {
+  DCHECK(cast_environment_->CurrentlyOn(CastEnvironment::VIDEO_DECODER));
+  video_decoder_->InitDecoder();
+}
+
 void VideoReceiver::GetRawVideoFrame(
     const VideoFrameDecodedCallback& callback) {
   DCHECK(cast_environment_->CurrentlyOn(CastEnvironment::MAIN));
   GetEncodedVideoFrame(base::Bind(&VideoReceiver::DecodeVideoFrame,
                                   weak_factory_.GetWeakPtr(),
                                   callback));
 }
 
 // Called when we have a frame to decode.
 void VideoReceiver::DecodeVideoFrame(
@@ skipping 297 matching lines @@
 }
 
 void VideoReceiver::SendNextRtcpReport() {
   DCHECK(cast_environment_->CurrentlyOn(CastEnvironment::MAIN));
   rtcp_->SendRtcpFromRtpReceiver(NULL, NULL);
   ScheduleNextRtcpReport();
 }
 
 }  // namespace cast
 }  // namespace media