Issue 7942011: Support setting 'better' and using it in expectations.

Issue 7942011: Support setting 'better' and using it in expectations. (Closed)

Created:
9 years, 3 months ago by cmp

Modified:
9 years, 1 month ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Support setting 'better' and using it in expectations. BUG=96937

Patch Set 2 : fix nits #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -8 lines)			Patch
	M	tools/perf_expectations/make_expectations.py	View	1	3 chunks	+19 lines, -7 lines	0 comments	Download
	M	tools/perf_expectations/perf_expectations.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

nsylvain

LGTM with nits http://codereview.chromium.org/7942011/diff/1/tools/perf_expectations/make_expectations.py File tools/perf_expectations/make_expectations.py (right): http://codereview.chromium.org/7942011/diff/1/tools/perf_expectations/make_expectations.py#newcode287 tools/perf_expectations/make_expectations.py:287: better = 'higher' i feel like ...

9 years, 3 months ago (2011-09-19 22:07:14 UTC) #2

cmp

http://codereview.chromium.org/7942011/diff/1/tools/perf_expectations/make_expectations.py File tools/perf_expectations/make_expectations.py (right): http://codereview.chromium.org/7942011/diff/1/tools/perf_expectations/make_expectations.py#newcode287 tools/perf_expectations/make_expectations.py:287: better = 'higher' On 2011/09/19 22:07:15, nsylvain wrote: > ...

9 years, 3 months ago (2011-09-19 22:11:55 UTC) #3

cmp

I can land this once the masters have been restarted to respect the 'better' flag ...

9 years, 3 months ago (2011-09-19 22:12:24 UTC) #4

cmp

9 years, 1 month ago (2011-11-17 22:07:15 UTC) #5

I landed this in http://codereview.chromium.org/8400009.  I'll mark this one as
closed.

Expand Messages | Collapse Messages