content/browser/frame_host/render_frame_host_manager.cc - Issue 789643005: PlzNavigate: make content unit tests work with browser side navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 789643005: PlzNavigate: make content unit tests work with browser side navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cancel-navigations

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_impl.cc ('K') | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('j') | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager.cc

diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc

index 51c9c241ec37466bb2fa073c3c32af10f25c6b61..0a341a66eb7ada2b770d48a7921ef52ab1313ad3 100644

--- a/content/browser/frame_host/render_frame_host_manager.cc

+++ b/content/browser/frame_host/render_frame_host_manager.cc

@@ -272,7 +272,7 @@ bool RenderFrameHostManager::ShouldCloseTabOnUnresponsiveRenderer() {

// If the tab becomes unresponsive during beforeunload while doing a

// cross-site navigation, proceed with the navigation. (This assumes that

// the pending RenderFrameHost is still responsive.)

- if (render_frame_host_->is_waiting_for_beforeunload_ack()) {

+ if (render_frame_host_->IsWaitingForBeforeUnloadACK()) {

// Haven't gotten around to starting the request, because we're still

// waiting for the beforeunload handler to finish. We'll pretend that it

// did finish, to let the navigation proceed. Note that there's a danger