chrome/browser/services/gcm/push_messaging_service_impl.cc - Issue 785993003: [Push] Register: require user-visible to be present in the manifest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/push_messaging_service_impl.cc

Issue 785993003: [Push] Register: require user-visible to be present in the manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/services/gcm/push_messaging_permission_context.cc ('K') | « chrome/browser/services/gcm/push_messaging_permission_context_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | chrome/test/data/push_messaging/bad_manifest.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/services/gcm/push_messaging_service_impl.cc

diff --git a/chrome/browser/services/gcm/push_messaging_service_impl.cc b/chrome/browser/services/gcm/push_messaging_service_impl.cc

index 80051f95a980c0820f098d9e6bf85442952a446d..501f6ce29543374cbec4a0c8a9f1b4ede685a47a 100644

--- a/chrome/browser/services/gcm/push_messaging_service_impl.cc

+++ b/chrome/browser/services/gcm/push_messaging_service_impl.cc

@@ -275,7 +275,7 @@ void PushMessagingServiceImpl::RegisterFromDocument(

gcm::PushMessagingPermissionContext* permission_context =

gcm::PushMessagingPermissionContextFactory::GetForProfile(profile_);

- if (permission_context == NULL) {

+ if (permission_context == NULL || !user_visible_only) {

Michael van Ouwerkerk 2014/12/10 18:36:33 nit: how about if (!permission_context || !user_vi

Miguel Garcia 2014/12/11 11:37:08 well that makes it look like both variables are th

RegisterEnd(callback,

std::string(),

content::PUSH_REGISTRATION_STATUS_PERMISSION_DENIED);