chrome/test/data/push_messaging/manifest.json - Issue 785993003: [Push] Register: require user-visible to be present in the manifest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/push_messaging/manifest.json

Issue 785993003: [Push] Register: require user-visible to be present in the manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test after mock behavior change that was recently introduced Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/push_messaging/manifest.json

diff --git a/chrome/test/data/push_messaging/manifest.json b/chrome/test/data/push_messaging/manifest.json

index 7499a635295c7610d8b72182f862280dbb937930..51cc951746ae735cbd085959965ddf1f829c4465 100644

--- a/chrome/test/data/push_messaging/manifest.json

+++ b/chrome/test/data/push_messaging/manifest.json

@@ -1,3 +1,4 @@

{

- "gcm_sender_id": "1234567890"

+ "gcm_sender_id": "1234567890",

+ "gcm_user_visible_only" : true

« no previous file with comments | « chrome/chrome_browser.gypi ('k') | chrome/test/data/push_messaging/manifest_without_user_visible_only.json » ('j') | no next file with comments »