chrome/test/data/push_messaging/bad_manifest.json - Issue 785993003: [Push] Register: require user-visible to be present in the manifest

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/push_messaging/bad_manifest.json

Issue 785993003: [Push] Register: require user-visible to be present in the manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/services/gcm/push_messaging_service_impl.cc ('K') | « chrome/chrome_browser.gypi ('k') | chrome/test/data/push_messaging/manifest.json » ('j') | chrome/test/data/push_messaging/push_test.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "gcm_sender_id": "1234567890"	2 "gcm_sender_id": "1234567890"

3 }	3 }
	Michael van Ouwerkerk 2014/12/10 18:36:33 It seems there can be more than one way of having It seems there can be more than one way of having a bad manifest: 1) no sender id and 2) no user visible only. Please name this manifest to make clear what the difference is e.g. 'manifest_without_user_visible_only.json'. Miguel Garcia 2014/12/11 11:37:08 Done. Show quoted text On 2014/12/10 18:36:33, Michael van Ouwerkerk wrote: > It seems there can be more than one way of having a bad manifest: 1) no sender > id and 2) no user visible only. Please name this manifest to make clear what the > difference is e.g. 'manifest_without_user_visible_only.json'. Done.
OLD	NEW