Ensure that before creating proxy of site A, RVH of site A is initialized.

content/browser/site_per_process_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/site_per_process_browsertest.h"
 
 #include "base/command_line.h"
 #include "base/strings/stringprintf.h"
 #include "content/browser/frame_host/cross_process_frame_connector.h"
 #include "content/browser/frame_host/frame_tree.h"
@@ skipping 377 matching lines @@
 
   // Navigate back to the parent's origin and ensure we return to the
   // parent's process.
   NavigateFrameToURL(child, http_url);
   EXPECT_EQ(http_url, observer.navigation_url());
   EXPECT_TRUE(observer.navigation_succeeded());
   EXPECT_EQ(shell()->web_contents()->GetSiteInstance(),
             child->current_frame_host()->GetSiteInstance());
 }
 
+IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,

[nasko, 2014/12/12 22:25:01]

nit: Add a comment about what this case is testing and a link to the bug.

[lazyboy, 2014/12/23 22:03:11]

Done.

+                       NavigateRemoteFrameToAKilledSiteInstance) {

[Charlie Reis, 2014/12/12 19:18:31]

nit: ToAKilledSiteInstance -> ToKilledProcess

[lazyboy, 2014/12/23 22:03:11]

Done.

+  GURL main_url(embedded_test_server()->GetURL("/site_per_process_main.html"));
+  NavigateToURL(shell(), main_url);
+
+  // It is safe to obtain the root frame tree node here, as it doesn't change.
+  FrameTreeNode* root =
+      static_cast<WebContentsImpl*>(shell()->web_contents())->
+          GetFrameTree()->root();
+
+  SitePerProcessWebContentsObserver observer(shell()->web_contents());
+
+  FrameTreeNode* first_child = root->child_at(0);

[Charlie Reis, 2014/12/12 19:18:31]

Before this, we should ASSERT_EQ(2U, root->child_count()), since we depend on
that below.

[lazyboy, 2014/12/23 22:03:11]

Done.

+  // Load cross-site page into first iframe.
+  GURL url = embedded_test_server()->GetURL("foo.com", "/title2.html");
+  NavigateFrameToURL(first_child, url);
+  EXPECT_TRUE(observer.navigation_succeeded());
+  EXPECT_EQ(url, observer.navigation_url());
+
+  // Kill that cross-site renderer.
+  RenderProcessHost* child_process =
+      first_child->current_frame_host()->GetProcess();
+  {

[Charlie Reis, 2014/12/12 19:18:31]

nit: No need for brace here if we're only doing one crash.

[lazyboy, 2014/12/23 22:03:11]

Done.

+    RenderProcessHostWatcher crash_observer(
+        child_process,
+        RenderProcessHostWatcher::WATCH_FOR_PROCESS_EXIT);
+    child_process->Shutdown(0, false);
+    crash_observer.Wait();
+  }
+
+  // Now navigate the second iframe to the same site as the first_child.
+  FrameTreeNode* second_child = root->child_at(1);
+  url = embedded_test_server()->GetURL("foo.com", "/title1.html");

[nasko, 2014/12/12 22:25:01]

nit: It seems strange to navigate to title2 first and 1 second :), very minor,
but let's flip it around as debugging is easier if they are consecutive.

[lazyboy, 2014/12/23 22:03:11]

Done.

+  NavigateFrameToURL(second_child, url);
+  EXPECT_TRUE(observer.navigation_succeeded());
+  EXPECT_EQ(url, observer.navigation_url());
+}
+
 // Crash a subframe and ensures its children are cleared from the FrameTree.
 // See http://crbug.com/338508.
 // TODO(creis): Disabled for flakiness; see http://crbug.com/405582.
 // TODO(creis): Enable this on Android when we can kill the process there.
 IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, DISABLED_CrashSubframe) {
   GURL main_url(embedded_test_server()->GetURL("/site_per_process_main.html"));
   NavigateToURL(shell(), main_url);
 
   StartFrameAtDataURL();
 
@@ skipping 417 matching lines @@
   // Check that a new process is created and is different from the top one and
   // the middle one.
   FrameTreeNode* bottom_child = root->child_at(0)->child_at(0);
   EXPECT_NE(shell()->web_contents()->GetSiteInstance(),
             bottom_child->current_frame_host()->GetSiteInstance());
   EXPECT_NE(root->child_at(0)->current_frame_host()->GetSiteInstance(),
             bottom_child->current_frame_host()->GetSiteInstance());
 }
 
 }  // namespace content