OLD | NEW |
1 Contributing to infra.git | 1 Contributing to infra.git |
2 ========================= | 2 ========================= |
3 | 3 |
4 Standard workflow | 4 Standard workflow |
5 ----------------- | 5 ----------------- |
6 Starting with an configured checkout, here's the standard workflow to make a | 6 Starting with an configured checkout, here's the standard workflow to make a |
7 modification to the source code: | 7 modification to the source code: |
8 | 8 |
9 * Make sure your code is up-to-date: run ``gclient sync`` anywhere in infra.git. | 9 * Make sure your code is up-to-date: run ``gclient sync`` anywhere in infra.git. |
10 * Create a new branch: ``git new-branch``. | 10 * Create a new branch: ``git new-branch``. |
11 * Make modifications, commit them using ``git commit``. | 11 * Make modifications, commit them using ``git commit``. |
12 * Upload your modification for review by running ``git cl upload``. This step | 12 * Upload your modification for review by running ``git cl upload``. This step |
13 runs the tests, which must pass. If they don't, go back to the previous step | 13 runs the tests, which must pass. If they don't, go back to the previous step |
14 to fix any issue. You can use ``test.py`` to run tests anytime. Make sure | 14 to fix any issue. You can use ``test.py`` to run tests anytime. Make sure |
15 you've added reviewers for your modifications. | 15 you've added reviewers for your modifications. |
16 * Once your code has been approved, you can commit it by clicking the 'commit' | 16 * Once your code has been approved, you can commit it by clicking the 'commit' |
17 checkbox on the code review tool, or by running ``git cl land`` if you're | 17 checkbox on the code review tool, or by running ``git cl land`` if you're |
18 a Chromium committer. | 18 a Chromium committer. |
19 | 19 |
20 | 20 |
21 Deployment process | 21 Deployment process |
22 ------------------ | 22 ------------------ |
23 As of September 2014 there is no formal deployment process. To make your changes | 23 As of September 2014 there is no formal deployment process. To make your changes |
24 live, you have to ask on chrome-troopers@google.com. | 24 live, you have to ask on chrome-troopers@google.com. |
25 | 25 |
26 | 26 |
27 How to add a dependency | 27 How to add a dependency |
28 ----------------------- | 28 ----------------------- |
29 Sometimes it is necessary to add a new Python package to the virtual | 29 Sometimes it is necessary to add a new Python package to the virtual |
30 environment. See instruction in ``bootstrap/README.md``. | 30 environment. See instructions in :doc:`bootstrap`. |
31 | 31 |
OLD | NEW |