Fixed debug mode

expect_tests/pipeline.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import contextlib
 import imp
 import inspect
 import logging
 import multiprocessing
 import os
@@ skipping 311 matching lines @@
   if opts.handler.stdin:
     sys.stdin = opts.handler.stdin
 
   SKIP = object()
   def process_test(run_ctx, subtest):
     """run_ctx: context manager
     subtest: Test or subclass of
     """
     logstream.reset()
     try:
-      with run_ctx(subtest):
-        with cover_ctx.update(include=subtest.coverage_includes()):
-          with use_chdir(cwd):
+      with cover_ctx.update(include=subtest.coverage_includes()):
+        with use_chdir(cwd):

[dnj, 2014/12/02 20:47:26]

Is the reason for this that the 'chdir' is necessary for 'run_ctx' to work? Is
it reasonable to have 'run_ctx' perform the 'chdir'? (If so, rename it to
something more obviously associated with chdir, such as 'run_ctx_in_chdir')

[pgervais, 2014/12/02 21:17:00]

TBH, I don't know. There's only an issue with the debugger, nothing else. It
does not seem to be related to the chdir but rather to the coverage, because I
remember seeing the same issue in the past. I'll try to invert chdir and run_ctx
to see if it still works.

[pgervais, 2014/12/02 21:32:06]

Yep, it works with use_chdir at the lowest level. I'll send another patchset.

+          with run_ctx(subtest):
             subresult = subtest.run()
 
     except Exception:
       result_queue.put_nowait(
         TestError(subtest, traceback.format_exc(),
                   logstream.getvalue().splitlines()))
       return SKIP
     if isinstance(subresult, TestError):
       result_queue.put_nowait(subresult)
       return SKIP
@@ skipping 177 matching lines @@
 
     if procs:
       error = opts.handler.result_stage_loop(opts, generate_objects(procs))
   except ResultStageAbort:
     pass
 
   if not kill_switch.is_set() and not result_queue.empty():
     error = True
 
   return error, kill_switch.is_set()