Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: content/common/push_messaging_messages.h

Issue 770023002: Push registration should read a "gcm_user_visible_only" key from the Manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment fix Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/push_messaging_messages.h
diff --git a/content/common/push_messaging_messages.h b/content/common/push_messaging_messages.h
index f6dbdd1b64bafba032389bccc1d0a83ce9895135..352404e414aaceaae4127fb9007b5f3d79b6c87e 100644
--- a/content/common/push_messaging_messages.h
+++ b/content/common/push_messaging_messages.h
@@ -5,6 +5,7 @@
// IPC messages for push messaging.
// Multiply-included message file, hence no include guard.
+#include "content/common/push_registration_params.h"
#include "content/public/common/push_messaging_status.h"
#include "ipc/ipc_message_macros.h"
#include "third_party/WebKit/public/platform/WebPushPermissionStatus.h"
@@ -20,6 +21,12 @@ IPC_ENUM_TRAITS_MAX_VALUE(
blink::WebPushPermissionStatus::WebPushPermissionStatusLast)
// Messages sent from the browser to the renderer.
+IPC_STRUCT_TRAITS_BEGIN(content::PushRegistrationParams)
+ IPC_STRUCT_TRAITS_MEMBER(sender_id)
+ IPC_STRUCT_TRAITS_MEMBER(user_visible_only)
+ IPC_STRUCT_TRAITS_MEMBER(user_gesture)
mlamouri (slow - plz ping) 2014/12/01 21:05:09 I wouldn't put |user_gesture| in that struct.
Peter Beverloo 2014/12/03 15:01:59 Acknowledged.
+IPC_STRUCT_TRAITS_END()
+
IPC_MESSAGE_ROUTED3(PushMessagingMsg_RegisterSuccess,
int32 /* callbacks_id */,
GURL /* push_endpoint */,
@@ -38,11 +45,10 @@ IPC_MESSAGE_ROUTED1(PushMessagingMsg_PermissionStatusFailure,
// Messages sent from the renderer to the browser.
-IPC_MESSAGE_CONTROL5(PushMessagingHostMsg_Register,
+IPC_MESSAGE_CONTROL4(PushMessagingHostMsg_Register,
int32 /* render_frame_id */,
int32 /* callbacks_id */,
- std::string /* sender_id */,
- bool /* user_gesture */,
+ content::PushRegistrationParams /* registration_params */,
int32 /* service_worker_provider_id */)
IPC_MESSAGE_CONTROL3(PushMessagingHostMsg_PermissionStatus,

Powered by Google App Engine
This is Rietveld 408576698