Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1481)

Unified Diff: content/browser/push_messaging/push_messaging_message_filter.h

Issue 770023002: Push registration should read a "gcm_user_visible_only" key from the Manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment fix Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/push_messaging/push_messaging_message_filter.h
diff --git a/content/browser/push_messaging/push_messaging_message_filter.h b/content/browser/push_messaging/push_messaging_message_filter.h
index 07b9a6439bde04bd67a25af81a08c24a57af247d..929c09408db297beed07124038f97223fd362186 100644
--- a/content/browser/push_messaging/push_messaging_message_filter.h
+++ b/content/browser/push_messaging/push_messaging_message_filter.h
@@ -9,6 +9,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
+#include "content/common/push_registration_params.h"
#include "content/public/browser/browser_message_filter.h"
#include "content/public/common/push_messaging_status.h"
#include "url/gurl.h"
@@ -18,6 +19,7 @@ class GURL;
namespace content {
class PushMessagingService;
+struct PushRegistrationParams;
class ServiceWorkerContextWrapper;
class PushMessagingMessageFilter : public BrowserMessageFilter {
@@ -34,8 +36,7 @@ class PushMessagingMessageFilter : public BrowserMessageFilter {
void OnRegister(int render_frame_id,
int callbacks_id,
- const std::string& sender_id,
- bool user_gesture,
+ const PushRegistrationParams& registration_params,
int service_worker_provider_id);
void OnPermissionStatusRequest(int render_frame_id,
@@ -44,8 +45,7 @@ class PushMessagingMessageFilter : public BrowserMessageFilter {
void DoRegister(int render_frame_id,
int callbacks_id,
- const std::string& sender_id,
- bool user_gesture,
+ const PushRegistrationParams& registration_params,
const GURL& origin,
int64 service_worker_registration_id);

Powered by Google App Engine
This is Rietveld 408576698