content/common/push_messaging_messages.h - Issue 770023002: Push registration should read a "gcm_user_visible_only" key from the Manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/push_messaging_messages.h

Issue 770023002: Push registration should read a "gcm_user_visible_only" key from the Manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/push_messaging/push_messaging_message_filter.cc ('k') | content/public/browser/push_messaging_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/push_messaging_messages.h

diff --git a/content/common/push_messaging_messages.h b/content/common/push_messaging_messages.h

index 33de790efdb70ef81cac8a6d3f4754a91eba065a..c284bebfdc0efb2dd2e58455eb5e89bb8202304e 100644

--- a/content/common/push_messaging_messages.h

+++ b/content/common/push_messaging_messages.h

@@ -61,7 +61,7 @@ IPC_MESSAGE_CONTROL5(PushMessagingHostMsg_RegisterFromDocument,

int32 /* render_frame_id */,

int32 /* request_id */,

std::string /* sender_id */,

- bool /* user_gesture */,

+ bool /* user_visible_only */,

int32 /* service_worker_provider_id */)

IPC_MESSAGE_CONTROL2(PushMessagingHostMsg_RegisterFromWorker,

« no previous file with comments | « content/browser/push_messaging/push_messaging_message_filter.cc ('k') | content/public/browser/push_messaging_service.h » ('j') | no next file with comments »