Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: content/public/common/manifest.cc

Issue 770023002: Push registration should read a "gcm_user_visible_only" key from the Manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment fix Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/common/manifest.h" 5 #include "content/public/common/manifest.h"
6 6
7 namespace content { 7 namespace content {
8 8
9 const double Manifest::Icon::kDefaultDensity = 1; 9 const double Manifest::Icon::kDefaultDensity = 1;
10 const size_t Manifest::kMaxIPCStringLength = 4 * 1024; 10 const size_t Manifest::kMaxIPCStringLength = 4 * 1024;
11 11
12 Manifest::Icon::Icon() 12 Manifest::Icon::Icon()
13 : density(kDefaultDensity) { 13 : density(kDefaultDensity) {
14 } 14 }
15 15
16 Manifest::Icon::~Icon() { 16 Manifest::Icon::~Icon() {
17 } 17 }
18 18
19 Manifest::Manifest() 19 Manifest::Manifest()
20 : display(DISPLAY_MODE_UNSPECIFIED), 20 : display(DISPLAY_MODE_UNSPECIFIED),
21 orientation(blink::WebScreenOrientationLockDefault) { 21 orientation(blink::WebScreenOrientationLockDefault),
22 gcm_user_visible_only(false) {
22 } 23 }
23 24
24 Manifest::~Manifest() { 25 Manifest::~Manifest() {
25 } 26 }
26 27
27 bool Manifest::IsEmpty() const { 28 bool Manifest::IsEmpty() const {
28 return name.is_null() && 29 return name.is_null() &&
29 short_name.is_null() && 30 short_name.is_null() &&
30 start_url.is_empty() && 31 start_url.is_empty() &&
31 display == DISPLAY_MODE_UNSPECIFIED && 32 display == DISPLAY_MODE_UNSPECIFIED &&
32 orientation == blink::WebScreenOrientationLockDefault && 33 orientation == blink::WebScreenOrientationLockDefault &&
33 icons.empty() && 34 icons.empty() &&
34 gcm_sender_id.is_null(); 35 gcm_sender_id.is_null() &&
36 !gcm_user_visible_only;
35 } 37 }
36 38
37 } // namespace content 39 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698