Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6183)

Unified Diff: chrome/browser/resources/chromeos/login/oobe_screen_eula.js

Issue 763563002: Implemented event-dispatching for button clicks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/oobe_screen_eula.js
diff --git a/chrome/browser/resources/chromeos/login/oobe_screen_eula.js b/chrome/browser/resources/chromeos/login/oobe_screen_eula.js
index 686023f8ae2817134f054d8aa4f893b01550d334..b43d666761708e8e15cb0ddf434f439f4940507a 100644
--- a/chrome/browser/resources/chromeos/login/oobe_screen_eula.js
+++ b/chrome/browser/resources/chromeos/login/oobe_screen_eula.js
@@ -86,25 +86,16 @@ login.createScreen('EulaScreen', 'eula', function() {
get buttons() {
var buttons = [];
- var backButton = this.ownerDocument.createElement('button');
- backButton.id = 'back-button';
+ var backButton = this.declareButton('back-button');
backButton.textContent = loadTimeData.getString('back');
-
- var self = this;
- backButton.addEventListener('click', function(e) {
- chrome.send('eulaBackButtonClicked');
- e.stopPropagation();
- });
buttons.push(backButton);
- var acceptButton = this.ownerDocument.createElement('button');
- acceptButton.id = 'accept-button';
+ var acceptButton = this.declareButton('accept-button');
acceptButton.disabled = true;
acceptButton.classList.add('preserve-disabled-state');
acceptButton.textContent = loadTimeData.getString('acceptAgreement');
acceptButton.addEventListener('click', function(e) {
$('eula').classList.add('loading'); // Mark EULA screen busy.
- chrome.send('eulaAcceptButtonClicked');
e.stopPropagation();
});
buttons.push(acceptButton);

Powered by Google App Engine
This is Rietveld 408576698