Implemented event-dispatching for button clicks.

Implemented event-dispatching for button clicks. This CL follows https://codereview.chromium.org/755203002/.

BUG=433797
TEST=manual

Committed: https://crrev.com/05daf706d1acd82acf25bcd37d41db7fdb493b0d
Cr-Commit-Position: refs/heads/master@{#306096}

[ygorshenin1, 2014-11-26 17:32:57]

ygorshenin@chromium.org changed reviewers:
+ antrim@chromium.org, dzhioev@chromium.org

[dzhioev (left Google), 2014-11-27 12:08:52]

https://codereview.chromium.org/763563002/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/screens/base_screen.h (right):

https://codereview.chromium.org/763563002/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screens/base_screen.h:83: virtual void
OnButtonClicked(const std::string& button_id);
I propose to rename this method to something more general. For example,
"OnUserActed(action_id)".

https://codereview.chromium.org/763563002/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/screens/eula_screen.cc (right):

https://codereview.chromium.org/763563002/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screens/eula_screen.cc:22: const char
kButtonIdAccept[] = "accept-button";
This constants should be defined in EulaModel, because they are part of model's
interface.

[Denis Kuznetsov (DE-MUC), 2014-11-27 13:51:41]

https://chromiumcodereview.appspot.com/763563002/diff/1/chrome/browser/chrome...
File chrome/browser/chromeos/login/screens/base_screen.h (right):

https://chromiumcodereview.appspot.com/763563002/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/screens/base_screen.h:83: virtual void
OnButtonClicked(const std::string& button_id);
On 2014/11/27 12:08:51, dzhioev wrote:
> I propose to rename this method to something more general. For example,
> "OnUserActed(action_id)". 

OnUserAction() seems better to me.

https://chromiumcodereview.appspot.com/763563002/diff/1/chrome/browser/chrome...
File chrome/browser/chromeos/login/screens/eula_screen.cc (right):

https://chromiumcodereview.appspot.com/763563002/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/screens/eula_screen.cc:22: const char
kButtonIdAccept[] = "accept-button";
On 2014/11/27 12:08:51, dzhioev wrote:
> This constants should be defined in EulaModel, because they are part of
model's
> interface.

Acknowledged.

https://chromiumcodereview.appspot.com/763563002/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/screens/eula_screen.cc:111: else
I'd prefer to call the parent in the else-case and let the parent take
appropriate action (logging/notreached/etc).

[ygorshenin1, 2014-11-27 14:11:13]

PTAL

https://codereview.chromium.org/763563002/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/screens/base_screen.h (right):

https://codereview.chromium.org/763563002/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screens/base_screen.h:83: virtual void
OnButtonClicked(const std::string& button_id);
On 2014/11/27 12:08:51, dzhioev wrote:
> I propose to rename this method to something more general. For example,
> "OnUserActed(action_id)". 

Done.

https://codereview.chromium.org/763563002/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/screens/eula_screen.cc (right):

https://codereview.chromium.org/763563002/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screens/eula_screen.cc:22: const char
kButtonIdAccept[] = "accept-button";
On 2014/11/27 12:08:51, dzhioev wrote:
> This constants should be defined in EulaModel, because they are part of
model's
> interface.

Done.

https://codereview.chromium.org/763563002/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screens/eula_screen.cc:111: else
On 2014/11/27 13:51:41, Denis Kuznetsov wrote:
> I'd prefer to call the parent in the else-case and let the parent take
> appropriate action (logging/notreached/etc).

Done.

[Denis Kuznetsov (DE-MUC), 2014-11-27 15:06:02]

lgtm

[dzhioev (left Google), 2014-11-27 15:36:21]

On 2014/11/27 15:06:02, Denis Kuznetsov wrote:
> lgtm

LGTM

[ygorshenin1, 2014-11-28 15:43:37]

The CQ bit was checked by ygorshenin@chromium.org

[commit-bot: I haz the power, 2014-11-28 15:44:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/763563002/60001

[commit-bot: I haz the power, 2014-11-28 16:27:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-28 16:27:42]

Patchset 4 (id:??) landed as
https://crrev.com/05daf706d1acd82acf25bcd37d41db7fdb493b0d
Cr-Commit-Position: refs/heads/master@{#306096}