scripts/tools/buildbot_tool_templates/master_source_cfg.py - Issue 761253003: Add a new buildbot-tool generator for master configs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/tools/buildbot_tool_templates/master_source_cfg.py

Issue 761253003: Add a new buildbot-tool generator for master configs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: add buildbot-tool, turn files into actual templates Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

	5 # This file is used by scripts/tools/buildbot-tool to generate master configs.
	agable 2014/12/09 21:13:24 I'm not convinced of the need for a master_source_ I'm not convinced of the need for a master_source_config.py. I think it makes it harder to see what's going on all in one place. I'd just put it directly in master.cfg. Dirk Pranke 2014/12/09 21:32:01 OK. I tend to agree, but I wasn't sure if it would Show quoted text On 2014/12/09 21:13:24, agable wrote: > I'm not convinced of the need for a master_source_config.py. I think it makes it > harder to see what's going on all in one place. I'd just put it directly in > master.cfg. OK. I tend to agree, but I wasn't sure if it would be more or less confusing to hack on the templates too much here.
	6

5 from master import gitiles_poller	7 from master import gitiles_poller

6	8

7	9

8 def Update(config, active_master, c):	10 def Update(config, active_master, c):

9 master_poller = gitiles_poller.GitilesPoller(	11 master_poller = gitiles_poller.GitilesPoller(

10 'https://chromium.googlesource.com/external/mojo')	12 '%(git_repo_url)s')

11	13

12 c['change_source'].append(master_poller)	14 c['change_source'].append(master_poller)

OLD	NEW