Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: chrome/browser/chromeos/login/screens/base_screen.h

Issue 755203002: Added usage of ScreenContext in EulaScreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed comments. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/screens/base_screen.h
diff --git a/chrome/browser/chromeos/login/screens/base_screen.h b/chrome/browser/chromeos/login/screens/base_screen.h
index 2cbde5956edd99ef67f578aa3b7dfb7dd9154084..cc3c197b32295aef7eaa8d6bc2cbbb934faf770a 100644
--- a/chrome/browser/chromeos/login/screens/base_screen.h
+++ b/chrome/browser/chromeos/login/screens/base_screen.h
@@ -73,6 +73,11 @@ class BaseScreen {
// Returns the identifier of the screen.
virtual std::string GetID() const;
+ // Called when context for the currenct screen was
+ // changed. Notification about this event comes from the JS
+ // counterpart.
Denis Kuznetsov (DE-MUC) 2014/11/25 17:31:16 Please keep it protected, use friend classes inste
ygorshenin1 2014/11/26 11:45:40 Done.
ygorshenin1 2014/11/26 11:45:40 Done.
+ virtual void OnContextChanged(const base::DictionaryValue& diff);
+
protected:
// Screen can call this method to notify framework that it have finished
// it's work with |outcome|.
@@ -82,11 +87,6 @@ class BaseScreen {
// about this event comes from the JS counterpart.
virtual void OnButtonPressed(const std::string& button_id);
- // Called when context for the currenct screen was
- // changed. Notification about this event comes from the JS
- // counterpart.
- virtual void OnContextChanged(const base::DictionaryValue* diff);
-
BaseScreenDelegate* get_base_screen_delegate() const {
return base_screen_delegate_;
}

Powered by Google App Engine
This is Rietveld 408576698