Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: components/login/screens/screen_context.cc

Issue 755203002: Added usage of ScreenContext in EulaScreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase, fix to Screen.initialize(). Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/login/screens/screen_context.h ('k') | ui/login/screen.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/login/screens/screen_context.cc
diff --git a/components/login/screens/screen_context.cc b/components/login/screens/screen_context.cc
index 5324164ee6af6283062e8bd79fd44a70c6ebd71c..93a1c92476e47199e70f4163175acd7c2a4f225f 100644
--- a/components/login/screens/screen_context.cc
+++ b/components/login/screens/screen_context.cc
@@ -147,12 +147,11 @@ void ScreenContext::ApplyChanges(const base::DictionaryValue& diff,
keys->clear();
keys->reserve(diff.size());
}
- base::DictionaryValue::Iterator it(diff);
- while (!it.IsAtEnd()) {
+
+ for (base::DictionaryValue::Iterator it(diff); !it.IsAtEnd(); it.Advance()) {
Set(it.key(), it.value().DeepCopy());
if (keys)
keys->push_back(it.key());
- it.Advance();
}
changes_.Clear();
}
« no previous file with comments | « components/login/screens/screen_context.h ('k') | ui/login/screen.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698