components/login/screens/screen_context.cc - Issue 755203002: Added usage of ScreenContext in EulaScreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/login/screens/screen_context.cc

Issue 755203002: Added usage of ScreenContext in EulaScreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/login/screens/screen_context.cc

diff --git a/components/login/screens/screen_context.cc b/components/login/screens/screen_context.cc

index 5324164ee6af6283062e8bd79fd44a70c6ebd71c..93a1c92476e47199e70f4163175acd7c2a4f225f 100644

--- a/components/login/screens/screen_context.cc

+++ b/components/login/screens/screen_context.cc

@@ -147,12 +147,11 @@ void ScreenContext::ApplyChanges(const base::DictionaryValue& diff,

keys->clear();

keys->reserve(diff.size());

}

- base::DictionaryValue::Iterator it(diff);

- while (!it.IsAtEnd()) {

+ for (base::DictionaryValue::Iterator it(diff); !it.IsAtEnd(); it.Advance()) {

Set(it.key(), it.value().DeepCopy());

if (keys)

keys->push_back(it.key());

- it.Advance();

}

changes_.Clear();

}