Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: chrome/browser/chromeos/login/screens/base_screen.h

Issue 755203002: Added usage of ScreenContext in EulaScreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments addressed. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/screens/base_screen.h
diff --git a/chrome/browser/chromeos/login/screens/base_screen.h b/chrome/browser/chromeos/login/screens/base_screen.h
index 2cbde5956edd99ef67f578aa3b7dfb7dd9154084..11a6618849f42e3bf3b5e56c050c9aae8d20bf56 100644
--- a/chrome/browser/chromeos/login/screens/base_screen.h
+++ b/chrome/browser/chromeos/login/screens/base_screen.h
@@ -82,10 +82,11 @@ class BaseScreen {
// about this event comes from the JS counterpart.
virtual void OnButtonPressed(const std::string& button_id);
- // Called when context for the currenct screen was
- // changed. Notification about this event comes from the JS
- // counterpart.
- virtual void OnContextChanged(const base::DictionaryValue* diff);
+ // The method is called each time some key in screen context is
+ // updated by JS side. Default implementation does nothing, so
+ // subclasses should override it in order to observe updates in
+ // screen context.
+ virtual void OnContextKeyUpdated(const ::login::ScreenContext::KeyType& key);
BaseScreenDelegate* get_base_screen_delegate() const {
return base_screen_delegate_;
@@ -98,12 +99,18 @@ class BaseScreen {
FRIEND_TEST_ALL_PREFIXES(EnrollmentScreenTest, TestSuccess);
FRIEND_TEST_ALL_PREFIXES(ProvisionedEnrollmentScreenTest, TestBackButton);
+ friend class BaseScreenHandler;
friend class NetworkScreenTest;
friend class ScreenManager;
friend class UpdateScreenTest;
void SetContext(::login::ScreenContext* context);
+ // Called when context for the current screen was
+ // changed. Notification about this event comes from the JS
+ // counterpart.
+ void OnContextChanged(const base::DictionaryValue& diff);
+
BaseScreenDelegate* base_screen_delegate_;
DISALLOW_COPY_AND_ASSIGN(BaseScreen);

Powered by Google App Engine
This is Rietveld 408576698