Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: src/ic-inl.h

Issue 75413002: Convert PatchCache (and related methods) to use types rather than objects/maps. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | src/list.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 HeapObject* IC::GetCodeCacheHolder(Isolate* isolate, 113 HeapObject* IC::GetCodeCacheHolder(Isolate* isolate,
114 Object* object, 114 Object* object,
115 InlineCacheHolderFlag holder) { 115 InlineCacheHolderFlag holder) {
116 if (object->IsSmi()) holder = PROTOTYPE_MAP; 116 if (object->IsSmi()) holder = PROTOTYPE_MAP;
117 Object* map_owner = holder == OWN_MAP 117 Object* map_owner = holder == OWN_MAP
118 ? object : object->GetPrototype(isolate); 118 ? object : object->GetPrototype(isolate);
119 return HeapObject::cast(map_owner); 119 return HeapObject::cast(map_owner);
120 } 120 }
121 121
122 122
123 InlineCacheHolderFlag IC::GetCodeCacheFlag(Type* type) {
124 if (type->Is(Type::Boolean()) ||
125 type->Is(Type::Number()) ||
126 type->Is(Type::String()) ||
127 type->Is(Type::Symbol())) {
128 return PROTOTYPE_MAP;
129 }
130 return OWN_MAP;
131 }
132
133
134 Handle<Map> IC::GetCodeCacheHolder(InlineCacheHolderFlag flag,
135 Type* type,
136 Isolate* isolate) {
137 if (flag == PROTOTYPE_MAP) {
138 Context* context = isolate->context()->native_context();
139 JSFunction* constructor;
140 if (type->Is(Type::Boolean())) {
141 constructor = context->boolean_function();
142 } else if (type->Is(Type::Number())) {
143 constructor = context->number_function();
144 } else if (type->Is(Type::String())) {
145 constructor = context->string_function();
146 } else {
147 ASSERT(type->Is(Type::Symbol()));
148 constructor = context->symbol_function();
149 }
150 return handle(JSObject::cast(constructor->instance_prototype())->map());
151 }
152 return type->AsClass();
153 }
154
155
123 } } // namespace v8::internal 156 } } // namespace v8::internal
124 157
125 #endif // V8_IC_INL_H_ 158 #endif // V8_IC_INL_H_
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | src/list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698