Issue 75413002: Convert PatchCache (and related methods) to use types rather than objects/maps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 75413002: Convert PatchCache (and related methods) to use types rather than objects/maps. (Closed)

Created:
7 years, 1 month ago by Toon Verwaest

Modified:
7 years, 1 month ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Convert PatchCache (and related methods) to use types rather than objects/maps. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17847

Patch Set 3 : Addressed comment #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+202 lines, -117 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1 2	2 chunks	+7 lines, -7 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1 2	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/ic.h	View	1 2	4 chunks	+22 lines, -7 lines	0 comments	Download
M	src/ic.cc	View	1 2	7 chunks	+61 lines, -47 lines	0 comments	Download
M	src/ic-inl.h	View	1 2	1 chunk	+33 lines, -0 lines	0 comments	Download
M	src/list.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects.cc	View	1 2	1 chunk	+17 lines, -1 line	0 comments	Download
M	src/stub-cache.h	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/stub-cache.cc	View		6 chunks	+41 lines, -37 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 2	2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

LGTM with nits https://chromiumcodereview.appspot.com/75413002/diff/30001/src/ic-inl.h File src/ic-inl.h (right): https://chromiumcodereview.appspot.com/75413002/diff/30001/src/ic-inl.h#newcode124 src/ic-inl.h:124: if (type->Is(Type::Boolean())) return PROTOTYPE_MAP; Nit: why ...

7 years, 1 month ago (2013-11-18 17:02:05 UTC) #2

Toon Verwaest

7 years, 1 month ago (2013-11-18 17:18:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r17847 (presubmit successful).

Expand Messages | Collapse Messages

Issue 75413002: Convert PatchCache (and related methods) to use types rather than objects/maps. (Closed)

Description

Patch Set 1 #

Patch Set 2 : X64 and ARM #

Patch Set 3 : Addressed comment #

Messages