Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: media/cast/rtcp/rtcp.h

Issue 74613004: Cast: Add capabity to send Receiver and Sender log messages over RTCP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rtcp_logging
Patch Set: Addressed comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/cast/rtcp/rtcp.cc » ('j') | media/cast/rtcp/rtcp.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/rtcp/rtcp.h
diff --git a/media/cast/rtcp/rtcp.h b/media/cast/rtcp/rtcp.h
index 92e72a859df3a291e85d7b20b4df733e7127b689..79e0c82a01e9d86a49cff1bc7c0bf333fa288c0b 100644
--- a/media/cast/rtcp/rtcp.h
+++ b/media/cast/rtcp/rtcp.h
@@ -91,15 +91,20 @@ class Rtcp {
// |sender_log_message| is optional; without it no log messages will be
// attached to the RTCP report; instead a normal RTCP send report will be
// sent.
- void SendRtcpFromRtpSender(const RtcpSenderLogMessage* sender_log_message);
+ // Additionally if all messages in |sender_log_message| does
+ // not fit in the packet the |sender_log_message| will contain the remaining
+ // unsent messages.
+ void SendRtcpFromRtpSender(RtcpSenderLogMessage* sender_log_message);
// |cast_message| and |receiver_log| is optional; if |cast_message| is
// provided the RTCP receiver report will append a Cast message containing
// Acks and Nacks; if |receiver_log| is provided the RTCP receiver report will
// append the log messages. If no argument is set a normal RTCP receiver
- // report will be sent.
+ // report will be sent. Additionally if all messages in |receiver_log| does
+ // not fit in the packet the |receiver_log| will contain the remaining unsent
+ // messages.
void SendRtcpFromRtpReceiver(const RtcpCastMessage* cast_message,
- const RtcpReceiverLogMessage* receiver_log);
+ RtcpReceiverLogMessage* receiver_log);
void IncomingRtcpPacket(const uint8* rtcp_buffer, size_t length);
bool Rtt(base::TimeDelta* rtt, base::TimeDelta* avg_rtt,
« no previous file with comments | « no previous file | media/cast/rtcp/rtcp.cc » ('j') | media/cast/rtcp/rtcp.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698