Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 745463003: Display telemetry chartjson output and result data on waterfall. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Added coverage. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium/api.py
diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py
index cdcee9fdd599a4c59654a67f3d101db2411db44b..0232e4f795537c932a82adfb6f240719f64cb99d 100644
--- a/scripts/slave/recipe_modules/chromium/api.py
+++ b/scripts/slave/recipe_modules/chromium/api.py
@@ -179,7 +179,7 @@ class ChromiumApi(recipe_api.RecipeApi):
python_mode=False, spawn_dbus=True, parallel=False,
revision=None, webkit_revision=None, master_class_name=None,
test_launcher_summary_output=None, flakiness_dash=None,
- perf_id=None, perf_config=None, **kwargs):
+ perf_id=None, perf_config=None, chartjson_file=False, **kwargs):
"""Return a runtest.py invocation."""
args = args or []
assert isinstance(args, list)
@@ -215,6 +215,10 @@ class ChromiumApi(recipe_api.RecipeApi):
full_args.append('--test-type=%s' % test_type)
if generate_json_file:
full_args.append('--generate-json-file')
+ if chartjson_file:
+ full_args.append('--chartjson-file')
+ full_args.append(self.m.json.output())
+ kwargs['step_test_data'] = lambda: self.m.json.test_api.output([])
if results_directory:
full_args.append('--results-directory=%s' % results_directory)
if test_launcher_summary_output:

Powered by Google App Engine
This is Rietveld 408576698