Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 745463003: Display telemetry chartjson output and result data on waterfall. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/steps.py » ('j') | scripts/slave/telemetry_utils.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium/api.py
diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py
index d91a7e39f566ac6725212f98fd8bbc2484bcddeb..f1ff7a20f65b223ada7c38163f2c5e9b3e9f0434 100644
--- a/scripts/slave/recipe_modules/chromium/api.py
+++ b/scripts/slave/recipe_modules/chromium/api.py
@@ -179,7 +179,7 @@ class ChromiumApi(recipe_api.RecipeApi):
python_mode=False, spawn_dbus=True, parallel=False,
revision=None, webkit_revision=None, master_class_name=None,
test_launcher_summary_output=None, flakiness_dash=None,
- perf_id=None, perf_config=None, **kwargs):
+ perf_id=None, perf_config=None, chartjson_file=False, **kwargs):
"""Return a runtest.py invocation."""
args = args or []
assert isinstance(args, list)
@@ -215,6 +215,9 @@ class ChromiumApi(recipe_api.RecipeApi):
full_args.append('--test-type=%s' % test_type)
if generate_json_file:
full_args.append('--generate-json-file')
+ if chartjson_file:
+ full_args.append('--chartjson-file')
ghost stip (do not use) 2014/11/21 21:17:54 you'll have to add a test case somewhere that call
+ full_args.append(self.m.json.output())
if results_directory:
full_args.append('--results-directory=%s' % results_directory)
if test_launcher_summary_output:
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/steps.py » ('j') | scripts/slave/telemetry_utils.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698