Display telemetry chartjson output and result data on waterfall.

Display telemetry chartjson output and result data on waterfall.

This enables chartjson output from telemetry tests and displays the perf results on the waterfall, along with a link to the json.output that was sent to the dashboard.


BUG=422173
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293125

[shatch, 2014-11-21 17:15:42]

simonhatch@chromium.org changed reviewers:
+ stip@chromium.org, sullivan@chromium.org

[shatch, 2014-11-21 17:21:48]

ptal

https://codereview.chromium.org/745463003/diff/1/scripts/slave/telemetry_util...
File scripts/slave/telemetry_utils.py (right):

https://codereview.chromium.org/745463003/diff/1/scripts/slave/telemetry_util...
scripts/slave/telemetry_utils.py:78: summary = chart_values['summary']
Are we only displaying summary results? This mostly matches the existing
waterfall, with some exceptions like page_load_time.

[sullivan, 2014-11-21 17:30:53]

lgtm

This looks great! Just a few questions:

* Can you link a demo buildbot output page, if you still have one running?
* chartjson is still disabled until bug 422174 is fixed; just want to
double-check that it works fine if we use buildbot output.

https://codereview.chromium.org/745463003/diff/1/scripts/slave/telemetry_util...
File scripts/slave/telemetry_utils.py (right):

https://codereview.chromium.org/745463003/diff/1/scripts/slave/telemetry_util...
scripts/slave/telemetry_utils.py:78: summary = chart_values['summary']
On 2014/11/21 17:21:48, shatch wrote:
> Are we only displaying summary results? This mostly matches the existing
> waterfall, with some exceptions like page_load_time.

I think displaying summary results is fine.

[shatch, 2014-11-21 19:25:24]

On 2014/11/21 17:30:53, sullivan wrote:
> lgtm
> 
> This looks great! Just a few questions:
> 
> * Can you link a demo buildbot output page, if you still have one running?
> * chartjson is still disabled until bug 422174 is fixed; just want to
> double-check that it works fine if we use buildbot output.
> 
>
https://codereview.chromium.org/745463003/diff/1/scripts/slave/telemetry_util...
> File scripts/slave/telemetry_utils.py (right):
> 
>
https://codereview.chromium.org/745463003/diff/1/scripts/slave/telemetry_util...
> scripts/slave/telemetry_utils.py:78: summary = chart_values['summary']
> On 2014/11/21 17:21:48, shatch wrote:
> > Are we only displaying summary results? This mostly matches the existing
> > waterfall, with some exceptions like page_load_time.
> 
> I think displaying summary results is fine.

Questions answered offline, updated patch to disable chartjson again until
422174 is fixed.

[sullivan, 2014-11-21 19:29:16]

still lgtm! stip, can you review?

[ghost stip (do not use), 2014-11-21 19:35:23]

Simon, can you run `scripts/slave/unittests/recipe_simulation_test.py train` and
commit the results?

[ghost stip (do not use), 2014-11-21 19:35:32]

s/commit/upload/

[shatch, 2014-11-21 20:15:08]

On 2014/11/21 19:35:32, stip wrote:
> s/commit/upload/

.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Trained 1537 tests in 4.156s (ran 1537 tests)

Coverage Report                                                                 
                                               Stmts   Miss  Cover   Missing
-------------------------------------------------------------------------------------------------------------------------------------------------------------
scripts/slave/recipe_modules/chromium/api                                       
                                                 293      2    99%   219-220
-------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                           
                                                9733      2    99%   

FATAL: Test coverage is not at 100%.

[ghost stip (do not use), 2014-11-21 21:17:54]

https://chromiumcodereview.appspot.com/745463003/diff/1/scripts/slave/recipe_...
File scripts/slave/recipe_modules/chromium/api.py (right):

https://chromiumcodereview.appspot.com/745463003/diff/1/scripts/slave/recipe_...
scripts/slave/recipe_modules/chromium/api.py:219:
full_args.append('--chartjson-file')
you'll have to add a test case somewhere that calls this. simplest place is to
add it in the perf recipe test, line 328 or 339 in
https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave...

[iannucci, 2014-11-22 00:22:03]

iannucci@chromium.org changed reviewers:
+ iannucci@chromium.org

[iannucci, 2014-11-22 00:22:04]

https://codereview.chromium.org/745463003/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium/api.py (right):

https://codereview.chromium.org/745463003/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium/api.py:220:
full_args.append(self.m.json.output())
my guess is that you're not mocking the output of this json placeholder in your
test.

That said... the exception that you're seeing is clearly obfuscatory.

[shatch, 2014-11-24 16:49:57]

Ok added a test to force coverage on the chartjson_file branch.

[ghost stip (do not use), 2014-11-25 06:12:39]

lgtm here, not sure if iannucci@ had any final comments

https://chromiumcodereview.appspot.com/745463003/diff/40001/scripts/slave/rec...
File scripts/slave/recipes/chromium.expected/test_chartjson_enabled.json (left):

https://chromiumcodereview.appspot.com/745463003/diff/40001/scripts/slave/rec...
scripts/slave/recipes/chromium.expected/test_chartjson_enabled.json:152:
"@@@STEP_LOG_LINE@json.output@    }, @@@",
I'm assuming blink_perf.all.release was deleted from an unrelated change

[shatch, 2014-11-25 14:19:48]

https://chromiumcodereview.appspot.com/745463003/diff/40001/scripts/slave/rec...
File scripts/slave/recipes/chromium.expected/test_chartjson_enabled.json (left):

https://chromiumcodereview.appspot.com/745463003/diff/40001/scripts/slave/rec...
scripts/slave/recipes/chromium.expected/test_chartjson_enabled.json:152:
"@@@STEP_LOG_LINE@json.output@    }, @@@",
On 2014/11/25 06:12:39, stip OoO 11-24 through 12-2 wrote:
> I'm assuming blink_perf.all.release was deleted from an unrelated change

This is a new file, so I'm not sure why it's doing a diff.

[shatch, 2014-11-26 18:22:17]

The CQ bit was checked by simonhatch@chromium.org

[commit-bot: I haz the power, 2014-11-26 18:23:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/745463003/40001

[commit-bot: I haz the power, 2014-11-26 18:25:17]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293125