Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Side by Side Diff: src/x64/ic-x64.cc

Issue 73893003: Remove unused keyed store "force generic". (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/ic-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1292 matching lines...) Expand 10 before | Expand all | Expand 10 after
1303 __ lea(r9, unmapped_location); 1303 __ lea(r9, unmapped_location);
1304 __ movq(r8, rax); 1304 __ movq(r8, rax);
1305 __ RecordWrite(rbx, 1305 __ RecordWrite(rbx,
1306 r9, 1306 r9,
1307 r8, 1307 r8,
1308 kDontSaveFPRegs, 1308 kDontSaveFPRegs,
1309 EMIT_REMEMBERED_SET, 1309 EMIT_REMEMBERED_SET,
1310 INLINE_SMI_CHECK); 1310 INLINE_SMI_CHECK);
1311 __ Ret(); 1311 __ Ret();
1312 __ bind(&slow); 1312 __ bind(&slow);
1313 GenerateMiss(masm, MISS); 1313 GenerateMiss(masm);
1314 } 1314 }
1315 1315
1316 1316
1317 void KeyedCallIC::GenerateNonStrictArguments(MacroAssembler* masm, 1317 void KeyedCallIC::GenerateNonStrictArguments(MacroAssembler* masm,
1318 int argc) { 1318 int argc) {
1319 // ----------- S t a t e ------------- 1319 // ----------- S t a t e -------------
1320 // rcx : function name 1320 // rcx : function name
1321 // rsp[0] : return address 1321 // rsp[0] : return address
1322 // rsp[8] : argument argc 1322 // rsp[8] : argument argc
1323 // rsp[16] : argument argc - 1 1323 // rsp[16] : argument argc - 1
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
1605 __ push(rcx); // key 1605 __ push(rcx); // key
1606 __ push(rax); // value 1606 __ push(rax); // value
1607 __ PushReturnAddressFrom(rbx); 1607 __ PushReturnAddressFrom(rbx);
1608 1608
1609 // Do tail-call to runtime routine. 1609 // Do tail-call to runtime routine.
1610 ExternalReference ref(IC_Utility(kKeyedStoreIC_Slow), masm->isolate()); 1610 ExternalReference ref(IC_Utility(kKeyedStoreIC_Slow), masm->isolate());
1611 __ TailCallExternalReference(ref, 3, 1); 1611 __ TailCallExternalReference(ref, 3, 1);
1612 } 1612 }
1613 1613
1614 1614
1615 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm, ICMissMode miss_mode) { 1615 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) {
1616 // ----------- S t a t e ------------- 1616 // ----------- S t a t e -------------
1617 // -- rax : value 1617 // -- rax : value
1618 // -- rcx : key 1618 // -- rcx : key
1619 // -- rdx : receiver 1619 // -- rdx : receiver
1620 // -- rsp[0] : return address 1620 // -- rsp[0] : return address
1621 // ----------------------------------- 1621 // -----------------------------------
1622 1622
1623 __ PopReturnAddressTo(rbx); 1623 __ PopReturnAddressTo(rbx);
1624 __ push(rdx); // receiver 1624 __ push(rdx); // receiver
1625 __ push(rcx); // key 1625 __ push(rcx); // key
1626 __ push(rax); // value 1626 __ push(rax); // value
1627 __ PushReturnAddressFrom(rbx); 1627 __ PushReturnAddressFrom(rbx);
1628 1628
1629 // Do tail-call to runtime routine. 1629 // Do tail-call to runtime routine.
1630 ExternalReference ref = miss_mode == MISS_FORCE_GENERIC 1630 ExternalReference ref =
1631 ? ExternalReference(IC_Utility(kKeyedStoreIC_MissForceGeneric), 1631 ExternalReference(IC_Utility(kKeyedStoreIC_Miss), masm->isolate());
1632 masm->isolate())
1633 : ExternalReference(IC_Utility(kKeyedStoreIC_Miss), masm->isolate());
1634 __ TailCallExternalReference(ref, 3, 1); 1632 __ TailCallExternalReference(ref, 3, 1);
1635 } 1633 }
1636 1634
1637 1635
1638 #undef __ 1636 #undef __
1639 1637
1640 1638
1641 Condition CompareIC::ComputeCondition(Token::Value op) { 1639 Condition CompareIC::ComputeCondition(Token::Value op) {
1642 switch (op) { 1640 switch (op) {
1643 case Token::EQ_STRICT: 1641 case Token::EQ_STRICT:
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
1702 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1700 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1703 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1701 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1704 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1702 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1705 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1703 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1706 } 1704 }
1707 1705
1708 1706
1709 } } // namespace v8::internal 1707 } } // namespace v8::internal
1710 1708
1711 #endif // V8_TARGET_ARCH_X64 1709 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/ic-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698