Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 73893003: Remove unused keyed store "force generic". (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/builtins.cc ('k') | src/ic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 689 matching lines...) Expand 10 before | Expand all | Expand 10 after
700 __ bind(&notin); 700 __ bind(&notin);
701 // The unmapped lookup expects that the parameter map is in ebx. 701 // The unmapped lookup expects that the parameter map is in ebx.
702 Operand unmapped_location = 702 Operand unmapped_location =
703 GenerateUnmappedArgumentsLookup(masm, ecx, ebx, edi, &slow); 703 GenerateUnmappedArgumentsLookup(masm, ecx, ebx, edi, &slow);
704 __ mov(unmapped_location, eax); 704 __ mov(unmapped_location, eax);
705 __ lea(edi, unmapped_location); 705 __ lea(edi, unmapped_location);
706 __ mov(edx, eax); 706 __ mov(edx, eax);
707 __ RecordWrite(ebx, edi, edx, kDontSaveFPRegs); 707 __ RecordWrite(ebx, edi, edx, kDontSaveFPRegs);
708 __ Ret(); 708 __ Ret();
709 __ bind(&slow); 709 __ bind(&slow);
710 GenerateMiss(masm, MISS); 710 GenerateMiss(masm);
711 } 711 }
712 712
713 713
714 static void KeyedStoreGenerateGenericHelper( 714 static void KeyedStoreGenerateGenericHelper(
715 MacroAssembler* masm, 715 MacroAssembler* masm,
716 Label* fast_object, 716 Label* fast_object,
717 Label* fast_double, 717 Label* fast_double,
718 Label* slow, 718 Label* slow,
719 KeyedStoreCheckMap check_map, 719 KeyedStoreCheckMap check_map,
720 KeyedStoreIncrementLength increment_length) { 720 KeyedStoreIncrementLength increment_length) {
(...skipping 823 matching lines...) Expand 10 before | Expand all | Expand 10 after
1544 __ push(eax); 1544 __ push(eax);
1545 __ push(Immediate(Smi::FromInt(NONE))); // PropertyAttributes 1545 __ push(Immediate(Smi::FromInt(NONE))); // PropertyAttributes
1546 __ push(Immediate(Smi::FromInt(strict_mode))); // Strict mode. 1546 __ push(Immediate(Smi::FromInt(strict_mode))); // Strict mode.
1547 __ push(ebx); // return address 1547 __ push(ebx); // return address
1548 1548
1549 // Do tail-call to runtime routine. 1549 // Do tail-call to runtime routine.
1550 __ TailCallRuntime(Runtime::kSetProperty, 5, 1); 1550 __ TailCallRuntime(Runtime::kSetProperty, 5, 1);
1551 } 1551 }
1552 1552
1553 1553
1554 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm, ICMissMode miss_mode) { 1554 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) {
1555 // ----------- S t a t e ------------- 1555 // ----------- S t a t e -------------
1556 // -- eax : value 1556 // -- eax : value
1557 // -- ecx : key 1557 // -- ecx : key
1558 // -- edx : receiver 1558 // -- edx : receiver
1559 // -- esp[0] : return address 1559 // -- esp[0] : return address
1560 // ----------------------------------- 1560 // -----------------------------------
1561 1561
1562 __ pop(ebx); 1562 __ pop(ebx);
1563 __ push(edx); 1563 __ push(edx);
1564 __ push(ecx); 1564 __ push(ecx);
1565 __ push(eax); 1565 __ push(eax);
1566 __ push(ebx); 1566 __ push(ebx);
1567 1567
1568 // Do tail-call to runtime routine. 1568 // Do tail-call to runtime routine.
1569 ExternalReference ref = miss_mode == MISS_FORCE_GENERIC 1569 ExternalReference ref =
1570 ? ExternalReference(IC_Utility(kKeyedStoreIC_MissForceGeneric), 1570 ExternalReference(IC_Utility(kKeyedStoreIC_Miss), masm->isolate());
1571 masm->isolate())
1572 : ExternalReference(IC_Utility(kKeyedStoreIC_Miss), masm->isolate());
1573 __ TailCallExternalReference(ref, 3, 1); 1571 __ TailCallExternalReference(ref, 3, 1);
1574 } 1572 }
1575 1573
1576 1574
1577 void StoreIC::GenerateSlow(MacroAssembler* masm) { 1575 void StoreIC::GenerateSlow(MacroAssembler* masm) {
1578 // ----------- S t a t e ------------- 1576 // ----------- S t a t e -------------
1579 // -- eax : value 1577 // -- eax : value
1580 // -- ecx : key 1578 // -- ecx : key
1581 // -- edx : receiver 1579 // -- edx : receiver
1582 // -- esp[0] : return address 1580 // -- esp[0] : return address
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
1681 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1679 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1682 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1680 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1683 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1681 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1684 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1682 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1685 } 1683 }
1686 1684
1687 1685
1688 } } // namespace v8::internal 1686 } } // namespace v8::internal
1689 1687
1690 #endif // V8_TARGET_ARCH_IA32 1688 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/builtins.cc ('k') | src/ic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698