Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: chrome/browser/android/tab_android.cc

Issue 73173002: Add ContextMenu support upstream for Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added tests, addressed comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/tab_android.cc
diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc
index 3a5bb7a1fad6a1dc6ea36830fcbacdd69ac422e0..8ba0cef98276cb56ef0076a84467b4d9af318fa6 100644
--- a/chrome/browser/android/tab_android.cc
+++ b/chrome/browser/android/tab_android.cc
@@ -31,6 +31,7 @@
#include "chrome/browser/translate/translate_tab_helper.h"
#include "chrome/browser/ui/alternate_error_tab_observer.h"
#include "chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.h"
+#include "chrome/browser/ui/android/context_menu_helper.h"
#include "chrome/browser/ui/android/infobars/infobar_container_android.h"
#include "chrome/browser/ui/android/tab_model/tab_model.h"
#include "chrome/browser/ui/android/tab_model/tab_model_list.h"
@@ -90,6 +91,7 @@ void BrowserTabContents::AttachTabHelpers(content::WebContents* contents) {
g_browser_process->GetApplicationLocale(),
autofill::AutofillManager::ENABLE_AUTOFILL_DOWNLOAD_MANAGER);
BookmarkTabHelper::CreateForWebContents(contents);
+ ContextMenuHelper::CreateForWebContents(contents);
CoreTabHelper::CreateForWebContents(contents);
extensions::TabHelper::CreateForWebContents(contents);
FaviconTabHelper::CreateForWebContents(contents);
@@ -289,7 +291,8 @@ void TabAndroid::InitWebContents(JNIEnv* env,
jobject obj,
jboolean incognito,
jobject jcontent_view_core,
- jobject jweb_contents_delegate) {
+ jobject jweb_contents_delegate,
+ jobject jcontext_menu_populator) {
content::ContentViewCore* content_view_core =
content::ContentViewCore::GetNativeContentViewCore(env,
jcontent_view_core);
@@ -301,6 +304,8 @@ void TabAndroid::InitWebContents(JNIEnv* env,
session_tab_id_.set_id(
SessionTabHelper::FromWebContents(web_contents())->session_id().id());
+ ContextMenuHelper::FromWebContents(web_contents())->SetPopulator(
+ jcontext_menu_populator);
WindowAndroidHelper::FromWebContents(web_contents())->
SetWindowAndroid(content_view_core->GetWindowAndroid());
CoreTabHelper::FromWebContents(web_contents())->set_delegate(this);

Powered by Google App Engine
This is Rietveld 408576698