Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: content/browser/frame_host/navigator_impl.h

Issue 730553002: PlzNavigate: Refactor unit test helper functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.h
diff --git a/content/browser/frame_host/navigator_impl.h b/content/browser/frame_host/navigator_impl.h
index e142b3fd1ffddc0178aec59e92aae5a7f8f3348c..bd343b6118b6ddfb0a417d35a972b22713544a36 100644
--- a/content/browser/frame_host/navigator_impl.h
+++ b/content/browser/frame_host/navigator_impl.h
@@ -35,6 +35,11 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
NavigatorImpl(NavigationControllerImpl* navigation_controller,
NavigatorDelegate* delegate);
+ // PlzNavigate
+ // Returns the navigation request for a given node. Used in tests.
+ NavigationRequest* GetNavigationRequestForNodeForTesting(
+ FrameTreeNode* frame_tree_node);
nasko 2014/11/15 00:32:51 nit: Move this after the Navigator interface overr
clamy 2014/11/17 12:51:12 Done.
+
// Navigator implementation.
NavigationController* GetController() override;
void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host,
@@ -86,7 +91,7 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
// Holds data used to track browser side navigation metrics.
struct NavigationMetricsData;
- friend class NavigatorTest;
+ friend class NavigatorTestWithBrowserSideNavigation;
~NavigatorImpl() override;
// Navigates to the given entry, which must be the pending entry. Private
« no previous file with comments | « no previous file | content/browser/frame_host/navigator_impl.cc » ('j') | content/browser/frame_host/navigator_impl_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698