sandbox/linux/syscall_broker/broker_client.cc - Issue 721553002: sandbox: Extend BrokerPolicy to support file creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/syscall_broker/broker_client.cc

Issue 721553002: sandbox: Extend BrokerPolicy to support file creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove serialization Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc ('K') | « sandbox/linux/sandbox_linux.gypi ('k') | sandbox/linux/syscall_broker/broker_file_permission.h » ('j') | sandbox/linux/syscall_broker/broker_file_permission.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sandbox/linux/syscall_broker/broker_client.cc

diff --git a/sandbox/linux/syscall_broker/broker_client.cc b/sandbox/linux/syscall_broker/broker_client.cc

index e63205ffae9dd6464d2ee00f0358be477ee72c3d..26ab6ab4692cec1db7b07e8c2a64b6f2e58ee9f2 100644

--- a/sandbox/linux/syscall_broker/broker_client.cc

+++ b/sandbox/linux/syscall_broker/broker_client.cc

@@ -54,7 +54,8 @@ int BrokerClient::PathAndFlagsSyscall(IPCCommand syscall_type,

// IPC.

if (fast_check_in_client_) {

if (syscall_type == COMMAND_OPEN &&

- !broker_policy_.GetFileNameIfAllowedToOpen(pathname, flags, NULL)) {

+ !broker_policy_.GetFileNameIfAllowedToOpen(pathname, flags, NULL,

Jorge Lucangeli Obes 2014/11/20 00:13:20 Given that we have two NULL arguments now, it migh

leecam 2014/11/20 00:56:38 Done.

+ NULL)) {

return -broker_policy_.denied_errno();

}

if (syscall_type == COMMAND_ACCESS &&