content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 720313004: Add autocapitalize support to IME support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 720313004: Add autocapitalize support to IME support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pass and use inputmode for auto-capitalization settings Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/ime_adapter_android.cc ('K') | « content/common/view_messages.h ('k') | content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index f32ec777efd211f0e59bcf39ea1d6b2b1dc7b87d..c1f44810459a33bf3dea41bac9014593dfe768e5 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -1487,7 +1487,7 @@ public class ContentViewCore

if (newConfig.keyboard != Configuration.KEYBOARD_NOKEYS) {

if (mNativeContentViewCore != 0) {

mImeAdapter.attach(nativeGetNativeImeAdapter(mNativeContentViewCore),

- ImeAdapter.getTextInputTypeNone(), 0 /* no flags */);

+ ImeAdapter.getTextInputTypeNone(), 0 /* no mode */, 0 /* no flags */);

}

mInputMethodManagerWrapper.restartInput(mContainerView);

}

@@ -2247,16 +2247,17 @@ public class ContentViewCore

@CalledByNative

private void updateImeAdapter(long nativeImeAdapterAndroid, int textInputType,

- int textInputFlags, String text, int selectionStart, int selectionEnd,

- int compositionStart, int compositionEnd, boolean showImeIfNeeded,

- boolean isNonImeChange) {

+ int textInputMode, int textInputFlags, String text,

+ int selectionStart, int selectionEnd, int compositionStart, int compositionEnd,

+ boolean showImeIfNeeded, boolean isNonImeChange) {

try {

TraceEvent.begin("ContentViewCore.updateImeAdapter");

mFocusedNodeEditable = (textInputType != ImeAdapter.getTextInputTypeNone());

if (!mFocusedNodeEditable) hidePastePopup();

mImeAdapter.updateKeyboardVisibility(

- nativeImeAdapterAndroid, textInputType, textInputFlags, showImeIfNeeded);

+ nativeImeAdapterAndroid, textInputType, textInputMode, textInputFlags,

+ showImeIfNeeded);

if (mInputConnection != null) {

mInputConnection.updateState(text, selectionStart, selectionEnd, compositionStart,