Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 720313004: Add autocapitalize support to IME support. (Closed)

Created:
6 years, 1 month ago by bcwhite
Modified:
4 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add autocapitalize support to IME support. Requires blink change: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ppKpYmZazlQ/BfLW4FY41eIJ BUG=116152

Patch Set 1 #

Patch Set 2 : remove 'unset' value; use 0 just like everywhere else #

Patch Set 3 : pass and use inputmode for auto-capitalization settings #

Total comments: 3

Patch Set 4 : rebased #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -15 lines) Patch
M content/browser/android/content_view_core_impl.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.cc View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/common/view_messages.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 3 2 chunks +6 lines, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java View 1 2 3 2 chunks +16 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 1 2 3 10 chunks +33 lines, -6 lines 1 comment Download
M content/renderer/render_widget.cc View 1 2 3 5 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
bcwhite
aurimas@chromium.org: Please review changes in .../java/... sievers@chromium.org: Please review changes in content/browser/renderer_host
6 years ago (2014-12-01 20:00:10 UTC) #2
aurimas (slooooooooow)
java bits LGTM after addressing the enum comment. https://chromiumcodereview.appspot.com/720313004/diff/40001/content/browser/renderer_host/ime_adapter_android.cc File content/browser/renderer_host/ime_adapter_android.cc (right): https://chromiumcodereview.appspot.com/720313004/diff/40001/content/browser/renderer_host/ime_adapter_android.cc#newcode93 content/browser/renderer_host/ime_adapter_android.cc:93: Java_ImeAdapter_initializeTextInputModes( ...
5 years, 11 months ago (2015-01-06 21:08:09 UTC) #3
bcwhite
https://chromiumcodereview.appspot.com/720313004/diff/40001/content/browser/renderer_host/ime_adapter_android.cc File content/browser/renderer_host/ime_adapter_android.cc (right): https://chromiumcodereview.appspot.com/720313004/diff/40001/content/browser/renderer_host/ime_adapter_android.cc#newcode93 content/browser/renderer_host/ime_adapter_android.cc:93: Java_ImeAdapter_initializeTextInputModes( On 2015/01/06 21:08:09, aurimas wrote: > Could we ...
5 years, 11 months ago (2015-01-07 15:21:32 UTC) #4
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/720313004/diff/40001/content/browser/renderer_host/ime_adapter_android.cc File content/browser/renderer_host/ime_adapter_android.cc (right): https://chromiumcodereview.appspot.com/720313004/diff/40001/content/browser/renderer_host/ime_adapter_android.cc#newcode93 content/browser/renderer_host/ime_adapter_android.cc:93: Java_ImeAdapter_initializeTextInputModes( On 2015/01/07 15:21:31, bcwhite wrote: > On 2015/01/06 ...
5 years, 11 months ago (2015-01-07 16:23:31 UTC) #5
aurimas (slooooooooow)
ping?
5 years, 9 months ago (2015-02-26 23:20:33 UTC) #6
no sievers
lgtm https://chromiumcodereview.appspot.com/720313004/diff/60001/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java File content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java (right): https://chromiumcodereview.appspot.com/720313004/diff/60001/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java#newcode123 content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:123: static int sTextInputModeLatinProse; We have a script now ...
5 years, 9 months ago (2015-02-27 20:06:10 UTC) #7
aurimas (slooooooooow)
+mlamouri There might be some overlapping work here between mlamouri and bcwhite. See https://chromiumcodereview.appspot.com/1003143002
5 years, 9 months ago (2015-03-18 19:05:11 UTC) #9
mlamouri (slow - plz ping)
5 years, 9 months ago (2015-03-18 20:00:55 UTC) #10 
On 2015/03/18 at 19:05:11, aurimas wrote:
> +mlamouri
> 
> There might be some overlapping work here between mlamouri and bcwhite.
> 
> See https://chromiumcodereview.appspot.com/1003143002

I thought inputmode was put on hold?

Powered by Google App Engine
This is Rietveld 408576698