Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3668)

Unified Diff: chrome/browser/services/gcm/push_messaging_browsertest.cc

Issue 718203004: [PUSH] Merge notifications and push messaging prompts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/push_messaging_browsertest.cc
diff --git a/chrome/browser/services/gcm/push_messaging_browsertest.cc b/chrome/browser/services/gcm/push_messaging_browsertest.cc
index d9ab8cb4cfdf218693275a95e60bccec7387bf7c..9b83d5a44cf71623ec5a1e5fbdaa39161e4c87c8 100644
--- a/chrome/browser/services/gcm/push_messaging_browsertest.cc
+++ b/chrome/browser/services/gcm/push_messaging_browsertest.cc
@@ -146,6 +146,8 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, RegisterSuccess) {
ASSERT_EQ("ok - service worker registered", script_result);
InfoBarResponder accepting_responder(browser(), true);
+ ASSERT_TRUE(RunScript("requestNotificationPermission()", &script_result));
+ ASSERT_EQ("permission status - granted", script_result);
ASSERT_TRUE(RunScript("registerPush()", &script_result));
EXPECT_EQ(std::string(kPushMessagingEndpoint) + " - 1", script_result);
@@ -155,13 +157,28 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, RegisterSuccess) {
EXPECT_EQ("1234567890", gcm_service()->last_registered_sender_ids()[0]);
}
-IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, RegisterFailureNoPermission) {
+IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
+ RegisterFailureNoPushPermission) {
+ std::string script_result;
+
+ ASSERT_TRUE(RunScript("registerServiceWorker()", &script_result));
+ ASSERT_EQ("ok - service worker registered", script_result);
+
+ ASSERT_TRUE(RunScript("registerPush()", &script_result));
+ EXPECT_EQ("AbortError - Registration failed - permission denied",
+ script_result);
+}
+
+IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
+ RegisterFailureNotificationsBlocked) {
std::string script_result;
ASSERT_TRUE(RunScript("registerServiceWorker()", &script_result));
ASSERT_EQ("ok - service worker registered", script_result);
InfoBarResponder cancelling_responder(browser(), false);
+ ASSERT_TRUE(RunScript("requestNotificationPermission();", &script_result));
+ ASSERT_EQ("permission status - denied", script_result);
ASSERT_TRUE(RunScript("registerPush()", &script_result));
EXPECT_EQ("AbortError - Registration failed - permission denied",
@@ -175,6 +192,8 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, RegisterFailureNoSenderId) {
ASSERT_EQ("ok - service worker registered", script_result);
InfoBarResponder accepting_responder(browser(), true);
+ ASSERT_TRUE(RunScript("requestNotificationPermission();", &script_result));
+ ASSERT_EQ("permission status - granted", script_result);
ASSERT_TRUE(RunScript("removeManifest()", &script_result));
ASSERT_EQ("manifest removed", script_result);
@@ -191,6 +210,8 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, PushEventSuccess) {
ASSERT_EQ("ok - service worker registered", script_result);
InfoBarResponder accepting_responder(browser(), true);
+ ASSERT_TRUE(RunScript("requestNotificationPermission();", &script_result));
+ ASSERT_EQ("permission status - granted", script_result);
ASSERT_TRUE(RunScript("registerPush()", &script_result));
EXPECT_EQ(std::string(kPushMessagingEndpoint) + " - 1", script_result);

Powered by Google App Engine
This is Rietveld 408576698