Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 71783003: Reland and fix "Add support for keyed-call on arrays of fast elements" (Closed)

Created:
7 years, 1 month ago by Toon Verwaest
Modified:
7 years, 1 month ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Reland and fix "Add support for keyed-call on arrays of fast elements" BUG= R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17782

Patch Set 1 #

Patch Set 2 : Test + fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+496 lines, -91 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +27 lines, -3 lines 0 comments Download
M src/ast.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/ast.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/code-stubs.h View 1 8 chunks +84 lines, -6 lines 0 comments Download
M src/code-stubs.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M src/compiler.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler.cc View 5 chunks +14 lines, -6 lines 0 comments Download
M src/deoptimizer.cc View 3 chunks +11 lines, -5 lines 0 comments Download
M src/frames.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/hydrogen.h View 3 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +18 lines, -6 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +23 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +27 lines, -3 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/ic.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic.cc View 2 chunks +48 lines, -8 lines 0 comments Download
M src/isolate.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/lithium.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects-inl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/type-info.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/type-info.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M src/typing.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +19 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/keyed-array-call.js View 1 chunk +23 lines, -27 lines 0 comments Download
A + test/mjsunit/regress/clear-keyed-call.js View 1 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 1 month ago (2013-11-14 15:41:45 UTC) #1
danno
lgtm
7 years, 1 month ago (2013-11-15 10:46:12 UTC) #2
Toon Verwaest
7 years, 1 month ago (2013-11-15 10:52:27 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r17782 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698