content/renderer/render_frame_impl.cc - Issue 715203004: PlzNavigate: Add a browser test for basic navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 715203004: PlzNavigate: Add a browser test for basic navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a browser test for renderer initiated navigations Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_side_navigation_browsertest.cc ('K') | « content/content_tests.gypi ('k') | content/test/content_browser_test_utils_internal.h » ('j') | content/test/content_browser_test_utils_internal.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index d2b1e163af84ba57c66d17be5a414d32fedcc45a..8f799cae6f2a81c654f8f916f67a825cda0ca20d 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -4169,6 +4169,7 @@ void RenderFrameImpl::BeginNavigation(blink::WebURLRequest* request) {

Send(new FrameHostMsg_BeginNavigation(routing_id_,

MakeBeginNavigationParams(request),

MakeCommonNavigationParams(request)));

+ Send(new FrameHostMsg_DidStartLoading(routing_id_, true));

nasko 2014/11/24 23:15:00 Shouldn't this be fired off before the BeginNaviga

clamy 2014/11/26 12:47:43 Done.

}

GURL RenderFrameImpl::GetLoadingUrl() const {