Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1675)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 714003002: Allow changing top controls height (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Some more fixes Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 10b20780722b4f83f2a24bcb9d2243cdfb3b39ac..8d6b883f6c09040597e8d4a90c704814dd8d9ebd 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -545,12 +545,21 @@ gfx::Size RenderWidgetHostViewAndroid::GetPhysicalBackingSize() const {
return content_view_core_->GetPhysicalBackingSize();
}
-float RenderWidgetHostViewAndroid::GetTopControlsLayoutHeight() const {
+bool RenderWidgetHostViewAndroid::GetTopControlsShrinkBlinkSize() const {
if (!content_view_core_)
return 0.f;
bokan 2014/11/20 15:09:32 This should be a bool right?
David Trainor- moved to gerrit 2014/11/20 20:57:27 Done.
- // The amount that the viewport size given to Blink is shrunk by the URL-bar.
- return content_view_core_->GetTopControlsLayoutHeightDip();
+ // Whether or not Blink's viewport size should be shrunk by the height of the
+ // URL-bar.
+ return content_view_core_->GetTopControlsShrinkBlinkSize();
+}
+
+float RenderWidgetHostViewAndroid::GetTopControlsHeight() const {
+ if (!content_view_core_)
+ return 0.f;
+
+ // The height of the top controls.
+ return content_view_core_->GetTopControlsHeightDip();
}
void RenderWidgetHostViewAndroid::UpdateCursor(const WebCursor& cursor) {

Powered by Google App Engine
This is Rietveld 408576698