Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 71373004: Add a flag to lexer-shell to replicate input file. (Closed)

Created:
7 years, 1 month ago by ulan
Modified:
7 years, 1 month ago
Reviewers:
marja
CC:
v8-dev
Visibility:
Public.

Description

Add a flag to lexer-shell to replicate input file. Fix a bug with time measurement for experimental lexer. R=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17697

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -41 lines) Patch
M src/lexer/experimental-scanner.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/lexer/experimental-scanner.cc View 1 chunk +18 lines, -11 lines 0 comments Download
M src/lexer/lexer-shell.cc View 8 chunks +19 lines, -29 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
7 years, 1 month ago (2013-11-13 14:48:34 UTC) #1
marja
lgtm
7 years, 1 month ago (2013-11-13 14:49:39 UTC) #2
ulan
7 years, 1 month ago (2013-11-13 14:59:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17697.

Powered by Google App Engine
This is Rietveld 408576698