| Index: src/mips/stub-cache-mips.cc
|
| diff --git a/src/mips/stub-cache-mips.cc b/src/mips/stub-cache-mips.cc
|
| index 471c25ef824d2fa59671642a4713f19cdcc49618..27be2d45147836c34c4ad0b2d96fe89665d6f8dc 100644
|
| --- a/src/mips/stub-cache-mips.cc
|
| +++ b/src/mips/stub-cache-mips.cc
|
| @@ -117,18 +117,14 @@ static void ProbeTable(Isolate* isolate,
|
| }
|
|
|
|
|
| -// Helper function used to check that the dictionary doesn't contain
|
| -// the property. This function may return false negatives, so miss_label
|
| -// must always call a backup property check that is complete.
|
| -// This function is safe to call if the receiver has fast properties.
|
| -// Name must be unique and receiver must be a heap object.
|
| -static void GenerateDictionaryNegativeLookup(MacroAssembler* masm,
|
| - Label* miss_label,
|
| - Register receiver,
|
| - Handle<Name> name,
|
| - Register scratch0,
|
| - Register scratch1) {
|
| +void StubCompiler::GenerateDictionaryNegativeLookup(MacroAssembler* masm,
|
| + Label* miss_label,
|
| + Register receiver,
|
| + Handle<Name> name,
|
| + Register scratch0,
|
| + Register scratch1) {
|
| ASSERT(name->IsUniqueName());
|
| + ASSERT(!receiver.is(scratch0));
|
| Counters* counters = masm->isolate()->counters();
|
| __ IncrementCounter(counters->negative_lookups(), 1, scratch0, scratch1);
|
| __ IncrementCounter(counters->negative_lookups_miss(), 1, scratch0, scratch1);
|
| @@ -408,15 +404,12 @@ void StubCompiler::GenerateLoadFunctionPrototype(MacroAssembler* masm,
|
| }
|
|
|
|
|
| -// Generate code to check that a global property cell is empty. Create
|
| -// the property cell at compilation time if no cell exists for the
|
| -// property.
|
| -static void GenerateCheckPropertyCell(MacroAssembler* masm,
|
| - Handle<GlobalObject> global,
|
| - Handle<Name> name,
|
| - Register scratch,
|
| - Label* miss) {
|
| - Handle<Cell> cell = GlobalObject::EnsurePropertyCell(global, name);
|
| +void StubCompiler::GenerateCheckPropertyCell(MacroAssembler* masm,
|
| + Handle<JSGlobalObject> global,
|
| + Handle<Name> name,
|
| + Register scratch,
|
| + Label* miss) {
|
| + Handle<Cell> cell = JSGlobalObject::EnsurePropertyCell(global, name);
|
| ASSERT(cell->value()->IsTheHole());
|
| __ li(scratch, Operand(cell));
|
| __ lw(scratch, FieldMemOperand(scratch, Cell::kValueOffset));
|
| @@ -433,7 +426,7 @@ void StoreStubCompiler::GenerateNegativeHolderLookup(
|
| Label* miss) {
|
| if (holder->IsJSGlobalObject()) {
|
| GenerateCheckPropertyCell(
|
| - masm, Handle<GlobalObject>::cast(holder), name, scratch1(), miss);
|
| + masm, Handle<JSGlobalObject>::cast(holder), name, scratch1(), miss);
|
| } else if (!holder->HasFastProperties() && !holder->IsJSGlobalProxy()) {
|
| GenerateDictionaryNegativeLookup(
|
| masm, miss, holder_reg, name, scratch1(), scratch2());
|
| @@ -468,7 +461,7 @@ void StoreStubCompiler::GenerateStoreTransition(MacroAssembler* masm,
|
|
|
| if (details.type() == CONSTANT) {
|
| Handle<Object> constant(descriptors->GetValue(descriptor), masm->isolate());
|
| - __ LoadObject(scratch1, constant);
|
| + __ li(scratch1, constant);
|
| __ Branch(miss_label, ne, value_reg, Operand(scratch1));
|
| } else if (FLAG_track_fields && representation.IsSmi()) {
|
| __ JumpIfNotSmi(value_reg, miss_label);
|
| @@ -844,7 +837,7 @@ static void GenerateFastApiDirectCall(MacroAssembler* masm,
|
| __ sw(cp, MemOperand(sp, FCA::kContextSaveIndex * kPointerSize));
|
| // Get the function and setup the context.
|
| Handle<JSFunction> function = optimization.constant_function();
|
| - __ LoadHeapObject(t1, function);
|
| + __ li(t1, function);
|
| __ lw(cp, FieldMemOperand(t1, JSFunction::kContextOffset));
|
| __ sw(t1, MemOperand(sp, FCA::kCalleeIndex * kPointerSize));
|
|
|
| @@ -1149,19 +1142,17 @@ class CallInterceptorCompiler BASE_EMBEDDED {
|
| };
|
|
|
|
|
| -// Calls GenerateCheckPropertyCell for each global object in the prototype chain
|
| -// from object to (but not including) holder.
|
| -static void GenerateCheckPropertyCells(MacroAssembler* masm,
|
| - Handle<JSObject> object,
|
| - Handle<JSObject> holder,
|
| - Handle<Name> name,
|
| - Register scratch,
|
| - Label* miss) {
|
| +void StubCompiler::GenerateCheckPropertyCells(MacroAssembler* masm,
|
| + Handle<JSObject> object,
|
| + Handle<JSObject> holder,
|
| + Handle<Name> name,
|
| + Register scratch,
|
| + Label* miss) {
|
| Handle<JSObject> current = object;
|
| while (!current.is_identical_to(holder)) {
|
| - if (current->IsGlobalObject()) {
|
| + if (current->IsJSGlobalObject()) {
|
| GenerateCheckPropertyCell(masm,
|
| - Handle<GlobalObject>::cast(current),
|
| + Handle<JSGlobalObject>::cast(current),
|
| name,
|
| scratch,
|
| miss);
|
| @@ -1364,26 +1355,6 @@ Register LoadStubCompiler::CallbackHandlerFrontend(
|
| }
|
|
|
|
|
| -void LoadStubCompiler::NonexistentHandlerFrontend(
|
| - Handle<JSObject> object,
|
| - Handle<JSObject> last,
|
| - Handle<Name> name,
|
| - Label* success,
|
| - Handle<GlobalObject> global) {
|
| - Label miss;
|
| -
|
| - HandlerFrontendHeader(object, receiver(), last, name, &miss);
|
| -
|
| - // If the last object in the prototype chain is a global object,
|
| - // check that the global property cell is empty.
|
| - if (!global.is_null()) {
|
| - GenerateCheckPropertyCell(masm(), global, name, scratch2(), &miss);
|
| - }
|
| -
|
| - HandlerFrontendFooter(name, success, &miss);
|
| -}
|
| -
|
| -
|
| void LoadStubCompiler::GenerateLoadField(Register reg,
|
| Handle<JSObject> holder,
|
| PropertyIndex field,
|
| @@ -1405,7 +1376,7 @@ void LoadStubCompiler::GenerateLoadField(Register reg,
|
|
|
| void LoadStubCompiler::GenerateLoadConstant(Handle<Object> value) {
|
| // Return the constant value.
|
| - __ LoadObject(v0, value);
|
| + __ li(v0, value);
|
| __ Ret();
|
| }
|
|
|
| @@ -2957,7 +2928,7 @@ Handle<Code> LoadStubCompiler::CompileLoadNonexistent(
|
| Handle<JSObject> object,
|
| Handle<JSObject> last,
|
| Handle<Name> name,
|
| - Handle<GlobalObject> global) {
|
| + Handle<JSGlobalObject> global) {
|
| Label success;
|
|
|
| NonexistentHandlerFrontend(object, last, name, &success, global);
|
| @@ -3061,10 +3032,7 @@ Handle<Code> LoadStubCompiler::CompileLoadGlobal(
|
| bool is_dont_delete) {
|
| Label success, miss;
|
|
|
| - __ CheckMap(
|
| - receiver(), scratch1(), Handle<Map>(object->map()), &miss, DO_SMI_CHECK);
|
| - HandlerFrontendHeader(
|
| - object, receiver(), Handle<JSObject>::cast(global), name, &miss);
|
| + HandlerFrontendHeader(object, receiver(), global, name, &miss);
|
|
|
| // Get the value from the cell.
|
| __ li(a3, Operand(cell));
|
| @@ -3085,7 +3053,7 @@ Handle<Code> LoadStubCompiler::CompileLoadGlobal(
|
| __ mov(v0, t0);
|
|
|
| // Return the generated code.
|
| - return GetICCode(kind(), Code::NORMAL, name);
|
| + return GetCode(kind(), Code::NORMAL, name);
|
| }
|
|
|
|
|
|
|