build/mac/tweak_info_plist.py - Issue 703073002: Fix tweak_info_plist's TOP path to be found relative to itself rather than the includer's SRCROOT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/mac/tweak_info_plist.py

Issue 703073002: Fix tweak_info_plist's TOP path to be found relative to itself rather than the includer's SRCROOT. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/mac/tweak_info_plist.py

diff --git a/build/mac/tweak_info_plist.py b/build/mac/tweak_info_plist.py

index 4a6c475aa1ca350c0c8faa6be0b9712a99be14f3..57f1b30a92593f68f9adc21bc8b8f74840a22d22 100755

--- a/build/mac/tweak_info_plist.py

+++ b/build/mac/tweak_info_plist.py

@@ -29,7 +29,8 @@ import subprocess

import sys

import tempfile

-TOP = os.path.join(env['SRCROOT'], '..')

+TOP = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(

Mark Mentovai 2014/11/06 04:06:13 Not sure the abspath is necessary. Without it, you

Yoyo Zhou 2014/11/06 17:44:37 Removed the abspath.

+ __file__))))

def _GetOutput(args):

« no previous file with comments | « no previous file | no next file » | no next file with comments »