Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/ic.h

Issue 70233009: Replace miss_mode flag with explicit Load/Store Force Generic methods. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 461 matching lines...) Expand 10 before | Expand all | Expand 10 after
472 }; 472 };
473 473
474 474
475 class KeyedLoadIC: public LoadIC { 475 class KeyedLoadIC: public LoadIC {
476 public: 476 public:
477 explicit KeyedLoadIC(FrameDepth depth, Isolate* isolate) 477 explicit KeyedLoadIC(FrameDepth depth, Isolate* isolate)
478 : LoadIC(depth, isolate) { 478 : LoadIC(depth, isolate) {
479 ASSERT(target()->is_keyed_load_stub()); 479 ASSERT(target()->is_keyed_load_stub());
480 } 480 }
481 481
482 MUST_USE_RESULT MaybeObject* LoadForceGeneric(Handle<Object> object,
483 Handle<Object> key);
484
482 MUST_USE_RESULT MaybeObject* Load(Handle<Object> object, 485 MUST_USE_RESULT MaybeObject* Load(Handle<Object> object,
483 Handle<Object> key, 486 Handle<Object> key);
484 ICMissMode force_generic);
485 487
486 // Code generator routines. 488 // Code generator routines.
487 static void GenerateMiss(MacroAssembler* masm, ICMissMode force_generic); 489 static void GenerateMiss(MacroAssembler* masm, ICMissMode force_generic);
488 static void GenerateRuntimeGetProperty(MacroAssembler* masm); 490 static void GenerateRuntimeGetProperty(MacroAssembler* masm);
489 static void GenerateInitialize(MacroAssembler* masm) { 491 static void GenerateInitialize(MacroAssembler* masm) {
490 GenerateMiss(masm, MISS); 492 GenerateMiss(masm, MISS);
491 } 493 }
492 static void GeneratePreMonomorphic(MacroAssembler* masm) { 494 static void GeneratePreMonomorphic(MacroAssembler* masm) {
493 GenerateMiss(masm, MISS); 495 GenerateMiss(masm, MISS);
494 } 496 }
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
673 }; 675 };
674 676
675 677
676 class KeyedStoreIC: public StoreIC { 678 class KeyedStoreIC: public StoreIC {
677 public: 679 public:
678 KeyedStoreIC(FrameDepth depth, Isolate* isolate) 680 KeyedStoreIC(FrameDepth depth, Isolate* isolate)
679 : StoreIC(depth, isolate) { 681 : StoreIC(depth, isolate) {
680 ASSERT(target()->is_keyed_store_stub()); 682 ASSERT(target()->is_keyed_store_stub());
681 } 683 }
682 684
685 MUST_USE_RESULT MaybeObject* StoreForceGeneric(Handle<Object> object,
686 Handle<Object> name,
687 Handle<Object> value);
683 MUST_USE_RESULT MaybeObject* Store(Handle<Object> object, 688 MUST_USE_RESULT MaybeObject* Store(Handle<Object> object,
684 Handle<Object> name, 689 Handle<Object> name,
685 Handle<Object> value, 690 Handle<Object> value);
686 ICMissMode force_generic);
687 691
688 // Code generators for stub routines. Only called once at startup. 692 // Code generators for stub routines. Only called once at startup.
689 static void GenerateInitialize(MacroAssembler* masm) { 693 static void GenerateInitialize(MacroAssembler* masm) {
690 GenerateMiss(masm, MISS); 694 GenerateMiss(masm, MISS);
691 } 695 }
692 static void GeneratePreMonomorphic(MacroAssembler* masm) { 696 static void GeneratePreMonomorphic(MacroAssembler* masm) {
693 GenerateMiss(masm, MISS); 697 GenerateMiss(masm, MISS);
694 } 698 }
695 static void GenerateMiss(MacroAssembler* masm, ICMissMode force_generic); 699 static void GenerateMiss(MacroAssembler* masm, ICMissMode force_generic);
696 static void GenerateSlow(MacroAssembler* masm); 700 static void GenerateSlow(MacroAssembler* masm);
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
903 DECLARE_RUNTIME_FUNCTION(MaybeObject*, StoreIC_MissFromStubFailure); 907 DECLARE_RUNTIME_FUNCTION(MaybeObject*, StoreIC_MissFromStubFailure);
904 DECLARE_RUNTIME_FUNCTION(MaybeObject*, ElementsTransitionAndStoreIC_Miss); 908 DECLARE_RUNTIME_FUNCTION(MaybeObject*, ElementsTransitionAndStoreIC_Miss);
905 DECLARE_RUNTIME_FUNCTION(MaybeObject*, BinaryOpIC_Miss); 909 DECLARE_RUNTIME_FUNCTION(MaybeObject*, BinaryOpIC_Miss);
906 DECLARE_RUNTIME_FUNCTION(MaybeObject*, CompareNilIC_Miss); 910 DECLARE_RUNTIME_FUNCTION(MaybeObject*, CompareNilIC_Miss);
907 DECLARE_RUNTIME_FUNCTION(MaybeObject*, ToBooleanIC_Miss); 911 DECLARE_RUNTIME_FUNCTION(MaybeObject*, ToBooleanIC_Miss);
908 912
909 913
910 } } // namespace v8::internal 914 } } // namespace v8::internal
911 915
912 #endif // V8_IC_H_ 916 #endif // V8_IC_H_
OLDNEW
« no previous file with comments | « no previous file | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698