content/browser/frame_host/render_frame_host_impl.cc - Issue 701953006: PlzNavigate: Speculatively spawns a renderer process for navigations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 701953006: PlzNavigate: Speculatively spawns a renderer process for navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR comments, mostly -- but not all -- nits. Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigator_impl_unittest.cc ('K') | « content/browser/frame_host/navigator_impl_unittest.cc ('k') | content/browser/frame_host/render_frame_host_manager.h » ('j') | content/browser/frame_host/render_frame_host_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index af0c6fcc9a43af5997fc99815ca11e7f44696bee..f875406b2127fb19be04e2356ceab52041728de0 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -1401,6 +1401,10 @@ void RenderFrameHostImpl::CommitNavigation(

// TODO(clamy): Check if we have to add security checks for the browser plugin

// guests.

+ // Get back to a clean state, in case we start a new navigation without

+ // completing a RFH swap or unload handler.

+ SetState(RenderFrameHostImpl::STATE_DEFAULT);

Send(new FrameMsg_CommitNavigation(

routing_id_, response->head, body->GetURL(),

common_params, commit_params));