Linux sandbox: change the return type of HandleRequest

Linux sandbox: change the return type of HandleRequest()

BrokerHost::HandleRequest() now returns an enum class and never exits on its
own.

Also move BrokerProcess to the syscall_broker namespace.

BUG=429028
Committed: https://crrev.com/d509bc772ac5865661f66c5bfd8076bcbe09dd5e
Cr-Commit-Position: refs/heads/master@{#303439}

[jln (very slow on Chromium), 2014-11-03 23:59:30]

jln@chromium.org changed reviewers:
+ mdempsky@chromium.org

[jln (very slow on Chromium), 2014-11-03 23:59:50]

Matthew: could you PTAL at this small CL?

[mdempsky, 2014-11-04 00:03:12]

lgtm

https://codereview.chromium.org/701443004/diff/1/sandbox/linux/syscall_broker...
File sandbox/linux/syscall_broker/broker_host.cc (right):

https://codereview.chromium.org/701443004/diff/1/sandbox/linux/syscall_broker...
sandbox/linux/syscall_broker/broker_host.cc:177: // TODO(jln): change this.
Is this TODONE?

[jln (very slow on Chromium), 2014-11-04 00:12:53]

https://codereview.chromium.org/701443004/diff/1/sandbox/linux/syscall_broker...
File sandbox/linux/syscall_broker/broker_host.cc (right):

https://codereview.chromium.org/701443004/diff/1/sandbox/linux/syscall_broker...
sandbox/linux/syscall_broker/broker_host.cc:177: // TODO(jln): change this.
On 2014/11/04 00:03:12, mdempsky wrote:
> Is this TODONE?

Done.

[jln (very slow on Chromium), 2014-11-04 00:12:57]

The CQ bit was checked by jln@chromium.org

[commit-bot: I haz the power, 2014-11-04 00:14:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/701443004/20001

[commit-bot: I haz the power, 2014-11-04 18:27:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-04 18:27:47]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[jln (very slow on Chromium), 2014-11-06 00:48:37]

The CQ bit was checked by jln@chromium.org

[commit-bot: I haz the power, 2014-11-06 00:49:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/701443004/20001

[commit-bot: I haz the power, 2014-11-06 04:42:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-06 04:42:06]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[jln (very slow on Chromium), 2014-11-10 08:09:05]

Patchset #3 (id:40001) has been deleted

[jln (very slow on Chromium), 2014-11-10 08:28:28]

Matthew: would you mind taking a look at PS#3?

I fixed a silly bug and added a unit test to check that the broker process
actually dies when the IPC channel disappears.

[mdempsky, 2014-11-10 08:36:35]

lgtm

https://chromiumcodereview.appspot.com/701443004/diff/60001/sandbox/linux/sys...
File sandbox/linux/syscall_broker/broker_process.h (right):

https://chromiumcodereview.appspot.com/701443004/diff/60001/sandbox/linux/sys...
sandbox/linux/syscall_broker/broker_process.h:72: // Close the IPC channel with
the other party. This should only be used
nit: I would put a blank line between the friend declaration and here.

[jln (very slow on Chromium), 2014-11-10 08:55:50]

https://chromiumcodereview.appspot.com/701443004/diff/60001/sandbox/linux/sys...
File sandbox/linux/syscall_broker/broker_process.h (right):

https://chromiumcodereview.appspot.com/701443004/diff/60001/sandbox/linux/sys...
sandbox/linux/syscall_broker/broker_process.h:72: // Close the IPC channel with
the other party. This should only be used
On 2014/11/10 08:36:35, mdempsky (Tokyo until Nov 14) wrote:
> nit: I would put a blank line between the friend declaration and here.

Done.

[jln (very slow on Chromium), 2014-11-10 08:56:00]

The CQ bit was checked by jln@chromium.org

[commit-bot: I haz the power, 2014-11-10 08:57:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/701443004/80001

[commit-bot: I haz the power, 2014-11-10 09:59:22]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2014-11-10 10:00:07]

Patchset 4 (id:??) landed as
https://crrev.com/d509bc772ac5865661f66c5bfd8076bcbe09dd5e
Cr-Commit-Position: refs/heads/master@{#303439}