Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: chrome/browser/guestview/webview/plugin_permission_helper.cc

Issue 69913002: Add UMA for <webview> APIs: a. ClearData, b. when Permission request is allowed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refine by permission granularity. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guestview/webview/plugin_permission_helper.cc
diff --git a/chrome/browser/guestview/webview/plugin_permission_helper.cc b/chrome/browser/guestview/webview/plugin_permission_helper.cc
index d223dbdcdf140318ee2d345685e5c5ec3f0a6fd9..11c3f7367258569127b79c18d0bac1cd36408dfd 100644
--- a/chrome/browser/guestview/webview/plugin_permission_helper.cc
+++ b/chrome/browser/guestview/webview/plugin_permission_helper.cc
@@ -100,7 +100,8 @@ void PluginPermissionHelper::OnRemovePluginPlaceholderHost(int placeholder_id) {
void PluginPermissionHelper::OnPermissionResponse(const std::string& identifier,
bool allow,
- const std::string& input) {
+ const std::string& input,
+ bool user_initiated) {
if (allow) {
RenderViewHost* host = web_contents()->GetRenderViewHost();
ChromePluginServiceFilter::GetInstance()->AuthorizeAllPlugins(
@@ -109,6 +110,7 @@ void PluginPermissionHelper::OnPermissionResponse(const std::string& identifier,
host->GetRoutingID(), identifier));
}
+ // Should we restrict this only for |user_initiated| = true?
lazyboy 2013/11/12 18:16:59 FYI: Pending question. For other permissions, I'm
Fady Samuel 2013/11/13 19:29:52 It's useful to record when plugin requests happen
lazyboy 2013/11/13 19:52:50 In that case we can record two separate pairs, a p
content::RecordAction(
allow ? content::UserMetricsAction("WebView.Guest.PluginLoadAllowed") :
content::UserMetricsAction("WebView.Guest.PluginLoadDenied"));

Powered by Google App Engine
This is Rietveld 408576698