chrome/browser/guestview/webview/plugin_permission_helper.cc - Issue 69913002: Add UMA for <webview> APIs: a. ClearData, b. when Permission request is allowed.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/guestview/webview/plugin_permission_helper.cc

Issue 69913002: Add UMA for <webview> APIs: a. ClearData, b. when Permission request is allowed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Shorten UMA string literals Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/guestview/webview/webview_guest.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/guestview/webview/plugin_permission_helper.h"	5 #include "chrome/browser/guestview/webview/plugin_permission_helper.h"

6	6

7 #include "chrome/browser/guestview/webview/webview_guest.h"	7 #include "chrome/browser/guestview/webview/webview_guest.h"

8 #include "chrome/browser/guestview/webview/webview_permission_types.h"	8 #include "chrome/browser/guestview/webview/webview_permission_types.h"

9 #include "chrome/browser/plugins/chrome_plugin_service_filter.h"	9 #include "chrome/browser/plugins/chrome_plugin_service_filter.h"

10 #include "chrome/common/render_messages.h"	10 #include "chrome/common/render_messages.h"

(...skipping 90 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
101 void PluginPermissionHelper::OnPermissionResponse(const std::string& identifier,	101 void PluginPermissionHelper::OnPermissionResponse(const std::string& identifier,

102 bool allow,	102 bool allow,

103 const std::string& input) {	103 const std::string& input) {

104 if (allow) {	104 if (allow) {

105 RenderViewHost* host = web_contents()->GetRenderViewHost();	105 RenderViewHost* host = web_contents()->GetRenderViewHost();

106 ChromePluginServiceFilter::GetInstance()->AuthorizeAllPlugins(	106 ChromePluginServiceFilter::GetInstance()->AuthorizeAllPlugins(

107 host->GetProcess()->GetID());	107 host->GetProcess()->GetID());

108 host->Send(new ChromeViewMsg_LoadBlockedPlugins(	108 host->Send(new ChromeViewMsg_LoadBlockedPlugins(

109 host->GetRoutingID(), identifier));	109 host->GetRoutingID(), identifier));

110 }	110 }

111

112 content::RecordAction(

113 allow ? content::UserMetricsAction("WebView.Guest.PluginLoadAllowed") :

114 content::UserMetricsAction("WebView.Guest.PluginLoadDenied"));

115 }	111 }

OLD	NEW