[Smart Lock] Add a setting to require close proximity in order for unlocking to work.

[Smart Lock] Add a setting to require close proximity in order for unlocking to work.

This setting is not yet wired up to anything.

BUG=403419
TEST=none
R=tengs@chromium.org

Committed: https://crrev.com/96bfc8d2849de91850059db5933b60940f4e0637
Cr-Commit-Position: refs/heads/master@{#302925}

[Tim Song, 2014-11-03 19:16:14]

Please gate this option behind a flag that we'll remove the flag once we get the
entire feature working.

https://codereview.chromium.org/696583002/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/696583002/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:10100: +          Allow unlocking this <ph
name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph> only when the phone is ZERO feet
away.
Since this string is not finalized, let's remove the number, and just say
something like "when the phone is very close." in case we can't merge strings
back.

[Ilya Sherman, 2014-11-04 03:03:43]

Hid the option behind a flag.

https://chromiumcodereview.appspot.com/696583002/diff/1/chrome/app/generated_...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/696583002/diff/1/chrome/app/generated_...
chrome/app/generated_resources.grd:10100: +          Allow unlocking this <ph
name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph> only when the phone is ZERO feet
away.
On 2014/11/03 19:16:13, Tim Song wrote:
> Since this string is not finalized, let's remove the number, and just say
> something like "when the phone is very close." in case we can't merge strings
> back.

I went with "only when the phone is within an arm's length away", which is
roughly the wording that Xiaowen suggested in person (specifically, she
recommended using the phrase "arm's length").  Not sure about using both
"within" and "away", though -- that feels a bit clunky.  Do you have any
suggestions on how to refine?

[Tim Song, 2014-11-04 20:40:23]

lgtm

https://chromiumcodereview.appspot.com/696583002/diff/1/chrome/app/generated_...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/696583002/diff/1/chrome/app/generated_...
chrome/app/generated_resources.grd:10100: +          Allow unlocking this <ph
name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph> only when the phone is ZERO feet
away.
On 2014/11/04 03:03:43, Ilya Sherman wrote:
> On 2014/11/03 19:16:13, Tim Song wrote:
> > Since this string is not finalized, let's remove the number, and just say
> > something like "when the phone is very close." in case we can't merge
strings
> > back.
> 
> I went with "only when the phone is within an arm's length away", which is
> roughly the wording that Xiaowen suggested in person (specifically, she
> recommended using the phrase "arm's length").  Not sure about using both
> "within" and "away", though -- that feels a bit clunky.  Do you have any
> suggestions on how to refine?

Given the lack of testing with various combinations of Chromebooks and phones, I
feel hesitant about quantifying this distance even by analogy. However, as long
as this is behind a flag, I think the wording is fine.

https://chromiumcodereview.appspot.com/696583002/diff/40001/components/proxim...
File components/proximity_auth/switches.cc (right):

https://chromiumcodereview.appspot.com/696583002/diff/40001/components/proxim...
components/proximity_auth/switches.cc:13: // secuirty.
nit: security

[Ilya Sherman, 2014-11-04 20:56:46]

https://chromiumcodereview.appspot.com/696583002/diff/40001/components/proxim...
File components/proximity_auth/switches.cc (right):

https://chromiumcodereview.appspot.com/696583002/diff/40001/components/proxim...
components/proximity_auth/switches.cc:13: // secuirty.
On 2014/11/04 20:40:23, Tim Song wrote:
> nit: security

Done.

[Ilya Sherman, 2014-11-04 20:57:48]

isherman@chromium.org changed reviewers:
+ estade@chromium.org

[Ilya Sherman, 2014-11-04 20:57:48]

+Evan for OWNERS approval for WebUI changes (both the resources and the
handler).

[Evan Stade, 2014-11-05 22:24:16]

webui lgtm with nits

https://chromiumcodereview.appspot.com/696583002/diff/80001/chrome/browser/re...
File chrome/browser/resources/options/browser_options.html (right):

https://chromiumcodereview.appspot.com/696583002/diff/80001/chrome/browser/re...
chrome/browser/resources/options/browser_options.html:558:
metric="Options_EasyUnlockRequireProximity"
nit: wrong indentation (see rest of file)

https://chromiumcodereview.appspot.com/696583002/diff/80001/chrome/browser/re...
File chrome/browser/resources/options/browser_options.js (right):

https://chromiumcodereview.appspot.com/696583002/diff/80001/chrome/browser/re...
chrome/browser/resources/options/browser_options.js:545:
$('easy-unlock-enable-proximity-detection').hidden = false;
nit: foo.hidden = !condition;

[Ilya Sherman, 2014-11-05 22:40:58]

https://chromiumcodereview.appspot.com/696583002/diff/80001/chrome/browser/re...
File chrome/browser/resources/options/browser_options.html (right):

https://chromiumcodereview.appspot.com/696583002/diff/80001/chrome/browser/re...
chrome/browser/resources/options/browser_options.html:558:
metric="Options_EasyUnlockRequireProximity"
On 2014/11/05 22:24:16, Evan Stade wrote:
> nit: wrong indentation (see rest of file)

Done.

https://chromiumcodereview.appspot.com/696583002/diff/80001/chrome/browser/re...
File chrome/browser/resources/options/browser_options.js (right):

https://chromiumcodereview.appspot.com/696583002/diff/80001/chrome/browser/re...
chrome/browser/resources/options/browser_options.js:545:
$('easy-unlock-enable-proximity-detection').hidden = false;
On 2014/11/05 22:24:16, Evan Stade wrote:
> nit: foo.hidden = !condition;

Done.

[Ilya Sherman, 2014-11-05 22:41:11]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2014-11-05 22:42:18]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-11-05 22:43:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/696583002/120001

[commit-bot: I haz the power, 2014-11-06 00:42:58]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2014-11-06 00:44:04]

Patchset 7 (id:??) landed as
https://crrev.com/96bfc8d2849de91850059db5933b60940f4e0637
Cr-Commit-Position: refs/heads/master@{#302925}