Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: media/cast/video_sender/video_encoder.cc

Issue 69603002: Incorporating logging into Cast (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: clean up Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/video_sender/video_encoder.cc
diff --git a/media/cast/video_sender/video_encoder.cc b/media/cast/video_sender/video_encoder.cc
index 42d1a88cc2c590b488508169194ac847ec90c75e..8de4a4709b02e930c215f071b1cd88c503aaeca7 100644
--- a/media/cast/video_sender/video_encoder.cc
+++ b/media/cast/video_sender/video_encoder.cc
@@ -65,6 +65,10 @@ void VideoEncoder::EncodeVideoFrameEncoderThread(
dynamic_config.latest_frame_id_to_reference);
vp8_encoder_->UpdateRates(dynamic_config.bit_rate);
+
+ uint32 rtp_timestamp = GetVideoRtpTimestamp(capture_time);
+ cast_environment_->Logging()->InsertFrameEvent(kVideoFrameSentToEncoder,
+ -1, rtp_timestamp);
Alpha Left Google 2013/11/14 00:29:24 Add a TODO here to replace -1 with something meani
mikhal 2013/11/14 17:42:31 Replaced with const, as in other locations. On 201
scoped_ptr<EncodedVideoFrame> encoded_frame(new EncodedVideoFrame());
bool retval = vp8_encoder_->Encode(*video_frame, encoded_frame.get());
@@ -80,6 +84,8 @@ void VideoEncoder::EncodeVideoFrameEncoderThread(
VLOG(1) << "Encoding resulted in an empty frame";
return;
}
+ cast_environment_->Logging()->InsertFrameEvent(kVideoFrameEncoded,
+ rtp_timestamp, -1);
Alpha Left Google 2013/11/14 00:29:24 Add a TODO here to replace -1 with something meani
mikhal 2013/11/14 17:42:31 see above On 2013/11/14 00:29:24, Alpha wrote:
cast_environment_->PostTask(CastEnvironment::MAIN, FROM_HERE,
base::Bind(frame_encoded_callback,
base::Passed(&encoded_frame), capture_time));

Powered by Google App Engine
This is Rietveld 408576698