Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: media/cast/rtcp/rtcp_unittest.cc

Issue 69603002: Incorporating logging into Cast (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: clean up Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/rtcp/rtcp_unittest.cc
diff --git a/media/cast/rtcp/rtcp_unittest.cc b/media/cast/rtcp/rtcp_unittest.cc
index 93d01e72db732b2c5281fd67e8b2da47b5bf81bf..19a0b28a76179db334a8eff681783e9ed127ceee 100644
--- a/media/cast/rtcp/rtcp_unittest.cc
+++ b/media/cast/rtcp/rtcp_unittest.cc
@@ -4,11 +4,13 @@
#include "base/test/simple_test_tick_clock.h"
#include "media/cast/cast_defines.h"
+#include "media/cast/cast_environment.h"
#include "media/cast/pacing/paced_sender.h"
#include "media/cast/rtcp/mock_rtcp_receiver_feedback.h"
#include "media/cast/rtcp/mock_rtcp_sender_feedback.h"
#include "media/cast/rtcp/rtcp.h"
#include "media/cast/rtcp/test_rtcp_packet_builder.h"
+#include "media/cast/test/fake_task_runner.h"
#include "testing/gmock/include/gmock/gmock.h"
namespace media {
@@ -27,7 +29,8 @@ static const int64 kAddedShortDelay= 100;
class LocalRtcpTransport : public PacedPacketSender {
public:
- explicit LocalRtcpTransport(base::SimpleTestTickClock* testing_clock)
+ LocalRtcpTransport(scoped_refptr<CastEnvironment> cast_environment,
+ base::SimpleTestTickClock* testing_clock)
: short_delay_(false),
testing_clock_(testing_clock) {}
@@ -58,11 +61,12 @@ class LocalRtcpTransport : public PacedPacketSender {
bool short_delay_;
Rtcp* rtcp_;
base::SimpleTestTickClock* testing_clock_;
+ scoped_refptr<CastEnvironment> cast_environment_;
};
class RtcpPeer : public Rtcp {
public:
- RtcpPeer(base::TickClock* clock,
+ RtcpPeer(scoped_refptr<CastEnvironment> cast_environment,
RtcpSenderFeedback* sender_feedback,
PacedPacketSender* const paced_packet_sender,
RtpSenderStatistics* rtp_sender_statistics,
@@ -72,7 +76,7 @@ class RtcpPeer : public Rtcp {
bool sending_media,
uint32 local_ssrc,
const std::string& c_name)
- : Rtcp(clock,
+ : Rtcp(cast_environment,
sender_feedback,
paced_packet_sender,
rtp_sender_statistics,
@@ -91,7 +95,11 @@ class RtcpPeer : public Rtcp {
class RtcpTest : public ::testing::Test {
protected:
RtcpTest()
- : transport_(&testing_clock_) {
+ : task_runner_(new test::FakeTaskRunner(&testing_clock_)),
+ cast_environment_(new CastEnvironment(&testing_clock_, task_runner_,
+ task_runner_, task_runner_, task_runner_, task_runner_,
+ false, false, false)),
+ transport_(cast_environment_, &testing_clock_) {
testing_clock_.Advance(
base::TimeDelta::FromMilliseconds(kStartMillisecond));
}
@@ -103,6 +111,8 @@ class RtcpTest : public ::testing::Test {
}
base::SimpleTestTickClock testing_clock_;
+ scoped_refptr<test::FakeTaskRunner> task_runner_;
+ scoped_refptr<CastEnvironment> cast_environment_;
LocalRtcpTransport transport_;
MockRtcpSenderFeedback mock_sender_feedback_;
};
@@ -110,7 +120,7 @@ class RtcpTest : public ::testing::Test {
TEST_F(RtcpTest, TimeToSend) {
base::TimeTicks start_time;
start_time += base::TimeDelta::FromMilliseconds(kStartMillisecond);
- Rtcp rtcp(&testing_clock_,
+ Rtcp rtcp(cast_environment_,
&mock_sender_feedback_,
&transport_,
NULL,
@@ -131,7 +141,7 @@ TEST_F(RtcpTest, TimeToSend) {
}
TEST_F(RtcpTest, BasicSenderReport) {
- Rtcp rtcp(&testing_clock_,
+ Rtcp rtcp(cast_environment_,
&mock_sender_feedback_,
&transport_,
NULL,
@@ -146,7 +156,7 @@ TEST_F(RtcpTest, BasicSenderReport) {
}
TEST_F(RtcpTest, BasicReceiverReport) {
- Rtcp rtcp(&testing_clock_,
+ Rtcp rtcp(cast_environment_,
&mock_sender_feedback_,
&transport_,
NULL,
@@ -165,7 +175,7 @@ TEST_F(RtcpTest, BasicCast) {
EXPECT_CALL(mock_sender_feedback_, OnReceivedCastFeedback(_)).Times(1);
// Media receiver.
- Rtcp rtcp(&testing_clock_,
+ Rtcp rtcp(cast_environment_,
&mock_sender_feedback_,
&transport_,
NULL,
@@ -193,8 +203,8 @@ TEST_F(RtcpTest, BasicCast) {
TEST_F(RtcpTest, Rtt) {
// Media receiver.
- LocalRtcpTransport receiver_transport(&testing_clock_);
- Rtcp rtcp_receiver(&testing_clock_,
+ LocalRtcpTransport receiver_transport(cast_environment_, &testing_clock_);
+ Rtcp rtcp_receiver(cast_environment_,
&mock_sender_feedback_,
&receiver_transport,
NULL,
@@ -206,8 +216,8 @@ TEST_F(RtcpTest, Rtt) {
kCName);
// Media sender.
- LocalRtcpTransport sender_transport(&testing_clock_);
- Rtcp rtcp_sender(&testing_clock_,
+ LocalRtcpTransport sender_transport(cast_environment_, &testing_clock_);
+ Rtcp rtcp_sender(cast_environment_,
&mock_sender_feedback_,
&sender_transport,
NULL,
@@ -302,7 +312,7 @@ TEST_F(RtcpTest, NtpAndTime) {
}
TEST_F(RtcpTest, WrapAround) {
- RtcpPeer rtcp_peer(&testing_clock_,
+ RtcpPeer rtcp_peer(cast_environment_,
&mock_sender_feedback_,
NULL,
NULL,
@@ -330,7 +340,7 @@ TEST_F(RtcpTest, WrapAround) {
}
TEST_F(RtcpTest, RtpTimestampInSenderTime) {
- RtcpPeer rtcp_peer(&testing_clock_,
+ RtcpPeer rtcp_peer(cast_environment_,
&mock_sender_feedback_,
NULL,
NULL,

Powered by Google App Engine
This is Rietveld 408576698