Incorporating logging into Cast

media/cast/cast_sender_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "media/cast/cast_sender_impl.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 
@@ skipping 16 matching lines @@
   LocalFrameInput(scoped_refptr<CastEnvironment> cast_environment,
                   base::WeakPtr<AudioSender> audio_sender,
                   base::WeakPtr<VideoSender> video_sender)
      : cast_environment_(cast_environment),
        audio_sender_(audio_sender),
        video_sender_(video_sender) {}
 
   virtual void InsertRawVideoFrame(const I420VideoFrame* video_frame,
                                    const base::TimeTicks& capture_time,
                                    const base::Closure callback) OVERRIDE {
+  cast_environment_->Logging()->InsertFrameEvent(kVideoFrameReceived,
+      GetVideoRtpTimestamp(capture_time), -1);

[Alpha Left Google, 2013/11/14 00:29:24]

Add a TODO here to replace -1 with something meaningful.

[mikhal, 2013/11/14 17:42:31]

Added a const value for his. The -1 will be a valid entry once the frame_id are
represented in ints (pwestin pending cl).
On 2013/11/14 00:29:24, Alpha wrote:

+
     cast_environment_->PostTask(CastEnvironment::MAIN, FROM_HERE,
         base::Bind(&VideoSender::InsertRawVideoFrame, video_sender_,
             video_frame, capture_time, callback));
   }
 
   virtual void InsertCodedVideoFrame(const EncodedVideoFrame* video_frame,
                                      const base::TimeTicks& capture_time,
                                      const base::Closure callback) OVERRIDE {
     cast_environment_->PostTask(CastEnvironment::MAIN, FROM_HERE,
         base::Bind(&VideoSender::InsertCodedVideoFrame, video_sender_,
             video_frame, capture_time, callback));
   }
 
   virtual void InsertAudio(const AudioBus* audio_bus,
                            const base::TimeTicks& recorded_time,
                            const base::Closure& done_callback) OVERRIDE {
+    cast_environment_->Logging()->InsertFrameEvent(kAudioFrameReceived,
+        GetVideoRtpTimestamp(recorded_time), -1);

[Alpha Left Google, 2013/11/14 00:29:24]

Add a TODO here to replace -1 with something meaningful.

[mikhal, 2013/11/14 17:42:31]

Same as above
On 2013/11/14 00:29:24, Alpha wrote:

     cast_environment_->PostTask(CastEnvironment::MAIN, FROM_HERE,
         base::Bind(&AudioSender::InsertAudio, audio_sender_,
             audio_bus, recorded_time, done_callback));
   }
 
   virtual void InsertCodedAudioFrame(const EncodedAudioFrame* audio_frame,
                                      const base::TimeTicks& recorded_time,
                                      const base::Closure callback) OVERRIDE {
     cast_environment_->PostTask(CastEnvironment::MAIN, FROM_HERE,
         base::Bind(&AudioSender::InsertCodedAudioFrame, audio_sender_,
@@ skipping 129 matching lines @@
 scoped_refptr<FrameInput> CastSenderImpl::frame_input() {
   return frame_input_;
 }
 
 scoped_refptr<PacketReceiver> CastSenderImpl::packet_receiver() {
   return packet_receiver_;
 }
 
 }  // namespace cast
 }  // namespace media